Differential D9863

Fix overlap of the first item in KFilePlacesView
ClosedPublic
Actions

Authored by fvogt on Jan 13 2018, 6:33 PM.

Details

Reviewers
dfaure
renatoo
Group Reviewers
Frameworks
Commits
R241:95f6e4929333: Fix overlap of the first item in KFilePlacesView
Summary

The first item overlapped both the section header and the item
below. This was caused by taking the spacing wrongly into account.
Additionally, the paint function's option's rect was not moved correctly,
as the unmodified option.rect was used in some places.

Test Plan

https://i.imgur.com/LJuACt2.png -> https://i.imgur.com/nYpdoXn.png

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jan 13 2018, 6:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 13 2018, 6:33 PM
fvogt requested review of this revision.Jan 13 2018, 6:33 PM
renatoo accepted this revision.Jan 16 2018, 5:29 PM

looks good

This revision is now accepted and ready to land.Jan 16 2018, 5:29 PM
Closed by commit R241:95f6e4929333: Fix overlap of the first item in KFilePlacesView (authored by fvogt). · Explain WhyJan 16 2018, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/kfileplacesview.cpp (45 lines)

Diff 25493

View Options

src/filewidgets/kfileplacesview.cpp

Loading...