Differential D9862

Don't create 2 msgbox (one of them crashes) when can't change rights.
AbandonedPublic
Actions

Authored by jtamate on Jan 13 2018, 6:19 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Summary

Copying several files to a file system where the rights can't be
changed, two dialogs asking for "Retry Skip Skip all Abort" where shown.
Pressing Skip all in the second dialog crashed dolphin.
Now only one dialog is shown and no crash pressing skip all.

CCBUG: 364039

Test Plan

The same as in https://phabricator.kde.org/D9005 and https://phabricator.kde.org/D9829

Diff Detail

Repository
R244 KCoreAddons
Branch
skip (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
jtamate created this revision.Jan 13 2018, 6:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 13 2018, 6:19 PM
jtamate requested review of this revision.Jan 13 2018, 6:19 PM
jtamate updated this revision to Diff 27429.Feb 17 2018, 9:27 PM

I still can trigger the crash without the patch with KF5 5.42 (opensuse)

Improved the patch it a little bit, including a QASSERT to know where the double finish originates.

jtamate added a reviewer: dfaure.Feb 17 2018, 9:27 PM
jtamate edited the summary of this revision. (Show Details)
jtamate updated this revision to Diff 27444.Feb 18 2018, 8:19 AM

Now with an Q_ASSERT that really shows the origin of the problem.

In the case of pressing the "skip All" button when can't change permissions is:

jtamate added a comment.Feb 18 2018, 8:21 AM

#10 0x00007ff925c93845 in KJob::finishJob(bool) (this=0x221d0d0, emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:101
#11 0x00007ff925c93f9b in KJob::emitResult() (this=0x221d0d0) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300
#12 0x00007ff927683a05 in KIO::FileCopyJob::slotResult(KJob*) (this=0x221d0d0, job=0x2bf3b50) at /g/5kde/frameworks/kio/src/core/filecopyjob.cpp:573
#13 0x00007ff925c931a8 in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<KJob*>, void, void (KCompositeJob::*)(KJob*)>::call(void (KCompositeJob::*)(KJob*), KCompositeJob*, void) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x221d0d0, arg=0x7ffed77d7280) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:136
#14 0x00007ff925c92d9e in QtPrivate::FunctionPointer<void (KCompositeJob::*)(KJob*)>::call<QtPrivate::List<KJob*>, void>(void (KCompositeJob::*)(KJob*), KCompositeJob*, void) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x221d0d0, arg=0x7ffed77d7280) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:169
#15 0x00007ff925c929b7 in QtPrivate::QSlotObject<void (KCompositeJob::*)(KJob*), QtPrivate::List<KJob*>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void, bool*) (which=1, this_=0x2b623d0, r=0x221d0d0, a=0x7ffed77d7280, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:398
#16 0x00007ff923d930cc in QMetaObject::activate(QObject*, int, int, void) () at /usr/lib64/libQt5Core.so.5
#17 0x00007ff925c958dd in KJob::result(KJob*, KJob::QPrivateSignal) (this=0x2bf3b50, _t1=0x2bf3b50, _t2=...) at /virtual/kde5/5kde/build/frameworks/kcoreaddons/src/lib/KF5CoreAddons_autogen/include/moc_kjob.cpp:569
#18 0x00007ff925c938b5 in KJob::finishJob(bool) (this=0x2bf3b50, emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:116
#19 0x00007ff925c93f9b in KJob::emitResult() (this=0x2bf3b50) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300
#20 0x00007ff92768c93e in KIO::SimpleJob::slotFinished() (this=0x2bf3b50) at /g/5kde/frameworks/kio/src/core/simplejob.cpp:232
#21 0x00007ff92768f23c in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (KIO::SimpleJob::*)()>::call(void (KIO::SimpleJob::*)(), KIO::SimpleJob*, void) (f=&virtual KIO::SimpleJob::slotFinished(), o=0x2bf3b50, arg=0x7ffed77d7530) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:136
#22 0x00007ff92768f00c in QtPrivate::FunctionPointer<void (KIO::SimpleJob::*)()>::call<QtPrivate::List<>, void>(void (KIO::SimpleJob::*)(), KIO::SimpleJob*, void) (f=&virtual KIO::SimpleJob::slotFinished(), o=0x2bf3b50, arg=0x7ffed77d7530) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:169
#23 0x00007ff92768eea7 in QtPrivate::QSlotObject<void (KIO::SimpleJob::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void, bool*) (which=1, this_=0x287bbd0, r=0x2bf3b50, a=0x7ffed77d7530, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:398
#24 0x00007ff923d930cc in QMetaObject::activate(QObject*, int, int, void) () at /usr/lib64/libQt5Core.so.5
#25 0x00007ff92767163f in KIO::SlaveInterface::finished() (this=0x1ae9da0) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_slaveinterface.cpp:437
#26 0x00007ff92766f140 in KIO::SlaveInterface::dispatch(int, QByteArray const&) (this=0x1ae9da0, _cmd=104, rawdata=...) at /g/5kde/frameworks/kio/src/core/slaveinterface.cpp:160
#27 0x00007ff92766edbb in KIO::SlaveInterface::dispatch() (this=0x1ae9da0) at /g/5kde/frameworks/kio/src/core/slaveinterface.cpp:89
#28 0x00007ff927673598 in KIO::Slave::gotInput() (this=0x1ae9da0) at /g/5kde/frameworks/kio/src/core/slave.cpp:406
#29 0x00007ff927708675 in KIO::Slave::qt_static_metacall(QObject*, QMetaObject::Call, int, void) (_o=0x1ae9da0, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7ffed77d78f0) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/EWIEGA46WW/moc_slave.cpp:89
#30 0x00007ff923d92fca in QMetaObject::activate(QObject*, int, int, void) () at /usr/lib64/libQt5Core.so.5
#31 0x00007ff927618e75 in KIO::Connection::readyRead() (this=0x1a6bfe0) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:143
#32 0x00007ff927617c61 in KIO::ConnectionPrivate::dequeue() (this=0x1c817e0) at /g/5kde/frameworks/kio/src/core/connection.cpp:46
#33 0x00007ff927618c86 in KIO::Connection::qt_static_metacall(QObject*, QMetaObject::Call, int, void) (_o=0x1a6bfe0, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7ff90c00cbe0) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:87
#34 0x00007ff923d939b2 in QObject::event(QEvent*) () at /usr/lib64/libQt5Core.so.5
#35 0x00007ff9251bdf0c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#36 0x00007ff9251c5204 in QApplication::notify(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#37 0x00007ff923d64ea8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib64/libQt5Core.so.5
#38 0x00007ff923d67885 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib64/libQt5Core.so.5
#39 0x00007ff923dbd0f3 in postEventSourceDispatch(_GSource*, int (*)(void*), void*) () at /usr/lib64/libQt5Core.so.5
#40 0x00007ff91c1eaf57 in g_main_dispatch (context=0x7ff90c004fc0) at gmain.c:3142
#41 0x00007ff91c1eaf57 in g_main_context_dispatch (context=context@entry=0x7ff90c004fc0) at gmain.c:3795
#42 0x00007ff91c1eb190 in g_main_context_iterate (context=context@entry=0x7ff90c004fc0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3868
#43 0x00007ff91c1eb21c in g_main_context_iteration (context=0x7ff90c004fc0, may_block=1) at gmain.c:3929
#44 0x00007ff923dbc76f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#45 0x00007ff915ecffb1 in QPAEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5XcbQpa.so.5
#46 0x00007ff923d636ba in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#47 0x00007ff9253976a7 in QDialog::exec() () at /usr/lib64/libQt5Widgets.so.5
#48 0x00007ff92974e1ae in KIO::JobUiDelegate::askSkip(KJob*, QFlags<KIO::SkipDialog_Option>, QString const&) (this=0x7ff9299cd2e0 <(anonymous namespace)::Q_QGS_globalUiDelegate::innerFunction()::holder>, job=0x28aeef0, options=..., error_text=...) at /g/5kde/frameworks/kio/src/widgets/jobuidelegate.cpp:179
#49 0x00007ff92764a439 in KIO::CopyJobPrivate::slotResultErrorCopyingFiles(KJob*) (this=0x1dcc930, job=0x221d0d0) at /g/5kde/frameworks/kio/src/core/copyjob.cpp:1455
#50 0x00007ff92764983f in KIO::CopyJobPrivate::slotResultCopyingFiles(KJob*) (this=0x1dcc930, job=0x221d0d0) at /g/5kde/frameworks/kio/src/core/copyjob.cpp:1330
#51 0x00007ff92764f8bb in KIO::CopyJob::slotResult(KJob*) (this=0x28aeef0, job=0x221d0d0) at /g/5kde/frameworks/kio/src/core/copyjob.cpp:2136
#52 0x00007ff925c931a8 in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<KJob*>, void, void (KCompositeJob::*)(KJob*)>::call(void (KCompositeJob::*)(KJob*), KCompositeJob*, void) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x28aeef0, arg=0x7ffed77d8500) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:136
#53 0x00007ff925c92d9e in QtPrivate::FunctionPointer<void (KCompositeJob::*)(KJob*)>::call<QtPrivate::List<KJob*>, void>(void (KCompositeJob::*)(KJob*), KCompositeJob*, void) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x28aeef0, arg=0x7ffed77d8500) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:169
#54 0x00007ff925c929b7 in QtPrivate::QSlotObject<void (KCompositeJob::*)(KJob*), QtPrivate::List<KJob*>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void, bool*) (which=1, this_=0x26c3ef0, r=0x28aeef0, a=0x7ffed77d8500, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:398
#55 0x00007ff923d930cc in QMetaObject::activate(QObject*, int, int, void) () at /usr/lib64/libQt5Core.so.5
#56 0x00007ff925c958dd in KJob::result(KJob*, KJob::QPrivateSignal) (this=0x221d0d0, _t1=0x221d0d0, _t2=...) at /virtual/kde5/5kde/build/frameworks/kcoreaddons/src/lib/KF5CoreAddons_autogen/include/moc_kjob.cpp:569
#57 0x00007ff925c938b5 in KJob::finishJob(bool) (this=0x221d0d0, emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:116
#58 0x00007ff925c93f9b in KJob::emitResult() (this=0x221d0d0) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300
#59 0x00007ff927683764 in KIO::FileCopyJob::slotResult(KJob*) (this=0x221d0d0, job=0x1ab6560) at /g/5kde/frameworks/kio/src/core/filecopyjob.cpp:517
#60 0x00007ff925c931a8 in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<KJob*>, void, void (KCompositeJob::*)(KJob*)>::call(void (KCompositeJob::*)(KJob*), KCompositeJob*, void) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x221d0d0, arg=0x7ffed77d87b0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:136
#61 0x00007ff925c92d9e in QtPrivate::FunctionPointer<void (KCompositeJob::*)(KJob*)>::call<QtPrivate::List<KJob*>, void>(void (KCompositeJob::*)(KJob*), KCompositeJob*, void) (f=&virtual KCompositeJob::slotResult(KJob*), o=0x221d0d0, arg=0x7ffed77d87b0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:169
#62 0x00007ff925c929b7 in QtPrivate::QSlotObject<void (KCompositeJob::*)(KJob*), QtPrivate::List<KJob*>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void, bool*) (which=1, this_=0x2cd3210, r=0x221d0d0, a=0x7ffed77d87b0, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:398
#63 0x00007ff923d930cc in QMetaObject::activate(QObject*, int, int, void) () at /usr/lib64/libQt5Core.so.5
#64 0x00007ff925c958dd in KJob::result(KJob*, KJob::QPrivateSignal) (this=0x1ab6560, _t1=0x1ab6560, _t2=...) at /virtual/kde5/5kde/build/frameworks/kcoreaddons/src/lib/KF5CoreAddons_autogen/include/moc_kjob.cpp:569
#65 0x00007ff925c938b5 in KJob::finishJob(bool) (this=0x1ab6560, emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:116
#66 0x00007ff925c93f9b in KJob::emitResult() (this=0x1ab6560) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300
#67 0x00007ff92768c93e in KIO::SimpleJob::slotFinished() (this=0x1ab6560) at /g/5kde/frameworks/kio/src/core/simplejob.cpp:232
#68 0x00007ff92768ca59 in KIO::SimpleJob::slotError(int, QString const&) (this=0x1ab6560, err=115, errorText=...) at /g/5kde/frameworks/kio/src/core/simplejob.cpp:245
#69 0x00007ff92768f125 in QtPrivate::FunctorCall<QtPrivate::IndexesList<0, 1>, QtPrivate::List<int, QString const&>, void, void (KIO::SimpleJob::*)(int, QString const&)>::call(void (KIO::SimpleJob::*)(int, QString const&), KIO::SimpleJob*, void) (f=(void (KIO::SimpleJob::*)(KIO::SimpleJob * const, int, const QString &)) 0x7ff92768c952 <KIO::SimpleJob::slotError(int, QString const&)>, o=0x1ab6560, arg=0x7ffed77d8b60) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:136
#70 0x00007ff92768ef82 in QtPrivate::FunctionPointer<void (KIO::SimpleJob::*)(int, QString const&)>::call<QtPrivate::List<int, QString const&>, void>(void (KIO::SimpleJob::*)(int, QString const&), KIO::SimpleJob*, void) (f=(void (KIO::SimpleJob::*)(KIO::SimpleJob * const, int, const QString &)) 0x7ff92768c952 <KIO::SimpleJob::slotError(int, QString const&)>, o=0x1ab6560, arg=0x7ffed77d8b60) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:169
#71 0x00007ff92768ecef in QtPrivate::QSlotObject<void (KIO::SimpleJob::*)(int, QString const&), QtPrivate::List<int, QString const&>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void, bool*) (which=1, this_=0x2cd46e0, r=0x1ab6560, a=0x7ffed77d8b60, ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:398
#72 0x00007ff923d930cc in QMetaObject::activate(QObject*, int, int, void) () at /usr/lib64/libQt5Core.so.5
#73 0x00007ff9276715e6 in KIO::SlaveInterface::error(int, QString const&) (this=0x19f7ae0, _t1=115, _t2=...) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_slaveinterface.cpp:425
#74 0x00007ff92766f2fa in KIO::SlaveInterface::dispatch(int, QByteArray const&) (this=0x19f7ae0, _cmd=102, rawdata=...) at /g/5kde/frameworks/kio/src/core/slaveinterface.cpp:192
#75 0x00007ff92766edbb in KIO::SlaveInterface::dispatch() (this=0x19f7ae0) at /g/5kde/frameworks/kio/src/core/slaveinterface.cpp:89
#76 0x00007ff927673598 in KIO::Slave::gotInput() (this=0x19f7ae0) at /g/5kde/frameworks/kio/src/core/slave.cpp:406
#77 0x00007ff927708675 in KIO::Slave::qt_static_metacall(QObject*, QMetaObject::Call, int, void) (_o=0x19f7ae0, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7ffed77d8eb0) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/EWIEGA46WW/moc_slave.cpp:89
#78 0x00007ff923d92fca in QMetaObject::activate(QObject*, int, int, void) () at /usr/lib64/libQt5Core.so.5
#79 0x00007ff927618e75 in KIO::Connection::readyRead() (this=0x1ee4830) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:143
#80 0x00007ff927617c61 in KIO::ConnectionPrivate::dequeue() (this=0x1a0d640) at /g/5kde/frameworks/kio/src/core/connection.cpp:46
#81 0x00007ff927618c86 in KIO::Connection::qt_static_metacall(QObject*, QMetaObject::Call, int, void) (_o=0x1ee4830, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x2cd5130) at /g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:87
#82 0x00007ff923d939b2 in QObject::event(QEvent*) () at /usr/lib64/libQt5Core.so.5
#83 0x00007ff9251bdf0c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#84 0x00007ff9251c5204 in QApplication::notify(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#85 0x00007ff923d64ea8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib64/libQt5Core.so.5
#86 0x00007ff923d67885 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib64/libQt5Core.so.5
#87 0x00007ff923dbd0f3 in postEventSourceDispatch(_GSource*, int (*)(void*), void*) () at /usr/lib64/libQt5Core.so.5
#88 0x00007ff91c1eaf57 in g_main_dispatch (context=0x7ff90c004fc0) at gmain.c:3142
#89 0x00007ff91c1eaf57 in g_main_context_dispatch (context=context@entry=0x7ff90c004fc0) at gmain.c:3795
#90 0x00007ff91c1eb190 in g_main_context_iterate (context=context@entry=0x7ff90c004fc0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3868
#91 0x00007ff91c1eb21c in g_main_context_iteration (context=0x7ff90c004fc0, may_block=1) at gmain.c:3929
#92 0x00007ff923dbc76f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#93 0x00007ff915ecffb1 in QPAEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5XcbQpa.so.5
#94 0x00007ff923d636ba in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#95 0x00007ff9253976a7 in QDialog::exec() () at /usr/lib64/libQt5Widgets.so.5
#96 0x00007ff925974079 in KMessageBox::createKMessageBox(QDialog*, QDialogButtonBox*, QIcon const&, QString const&, QStringList const&, QString const&, bool*, QFlags<KMessageBox::Option>, QString const&, QMessageBox::Icon) (dialog=0x2803fa0, buttons=0x28d3250, icon=..., text=..., strlist=..., ask=..., checkboxReturn=0x7ffed77d99df, options=..., details=..., notifyType=QMessageBox::Information) at /g/5kde/frameworks/kwidgetsaddons/src/kmessagebox.cpp:405
#97 0x00007ff925972b0f in KMessageBox::createKMessageBox(QDialog*, QDialogButtonBox*, QMessageBox::Icon, QString const&, QStringList const&, QString const&, bool*, QFlags<KMessageBox::Option>, QString const&) (dialog=0x2803fa0, buttons=0x28d3250, icon=QMessageBox::Information, text=..., strlist=..., ask=..., checkboxReturn=0x7ffed77d99df, options=..., details=...) at /g/5kde/frameworks/kwidgetsaddons/src/kmessagebox.cpp:209
#98 0x00007ff9259770de in KMessageBox::informationListInternal(QDialog*, QString const&, QStringList const&, QString const&, QString const&, KMessageBox::Options) (dialog=0x2803fa0, text=..., strlist=..., caption=..., dontShowAgainName=..., options=...) at /g/5kde/frameworks/kwidgetsaddons/src/kmessagebox.cpp:921
#99 0x00007ff9259776ce in KMessageBox::messageBoxInternal(QDialog*, KMessageBox::DialogType, QString const&, QString const&, KGuiItem const&, KGuiItem const&, KGuiItem const&, QString const&, KMessageBox::Options) (dialog=0x2803fa0, type=KMessageBox::Information, text=..., caption=..., buttonYes=..., buttonNo=..., buttonCancel=..., dontShow=..., options=...) at /g/5kde/frameworks/kwidgetsaddons/src/kmessagebox.cpp:980
#100 0x00007ff9259777d8 in KMessageBox::messageBox(QWidget*, KMessageBox::DialogType, QString const&, QString const&, KGuiItem const&, KGuiItem const&, KGuiItem const&, QString const&, QFlags<KMessageBox::Option>) (parent=0x0, type=KMessageBox::Information, text=..., caption=..., buttonYes=..., buttonNo=..., buttonCancel=..., dontShow=..., options=...) at /g/5kde/frameworks/kwidgetsaddons/src/kmessagebox.cpp:1000
#101 0x00007ff9294159da in KDialogJobUiDelegate::Private::next() (this=0x27ee910) at /g/5kde/frameworks/kjobwidgets/src/kdialogjobuidelegate.cpp:85
#102 0x00007ff929416197 in KDialogJobUiDelegate::Private::qt_static_metacall(QObject*, QMetaObject::Call, int, void) (_o=0x27ee910, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x1cca8e0) at /virtual/kde5/5kde/build/frameworks/kjobwidgets/src/KF5JobWidgets_autogen/include/kdialogjobuidelegate.moc:70
#103 0x00007ff923d939b2 in QObject::event(QEvent*) () at /usr/lib64/libQt5Core.so.5
#104 0x00007ff9251bdf0c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#105 0x00007ff9251c5204 in QApplication::notify(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5
#106 0x00007ff923d64ea8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib64/libQt5Core.so.5
#107 0x00007ff923d67885 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib64/libQt5Core.so.5
#108 0x00007ff923dbd0f3 in postEventSourceDispatch(_GSource*, int (*)(void*), void*) () at /usr/lib64/libQt5Core.so.5
#109 0x00007ff91c1eaf57 in g_main_dispatch (context=0x7ff90c004fc0) at gmain.c:3142
#110 0x00007ff91c1eaf57 in g_main_context_dispatch (context=context@entry=0x7ff90c004fc0) at gmain.c:3795
#111 0x00007ff91c1eb190 in g_main_context_iterate (context=context@entry=0x7ff90c004fc0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3868
#112 0x00007ff91c1eb21c in g_main_context_iteration (context=0x7ff90c004fc0, may_block=1) at gmain.c:3929
#113 0x00007ff923dbc76f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#114 0x00007ff915ecffb1 in QPAEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5XcbQpa.so.5
#115 0x00007ff923d636ba in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQt5Core.so.5
#116 0x00007ff923d6c1f4 in QCoreApplication::exec() () at /usr/lib64/libQt5Core.so.5
#117 0x00007ff92b83b91a in kdemain(int, char) (argc=<optimized out>, argv=<optimized out>) at /g/5kde/kde/applications/dolphin/src/main.cpp:163

jtamate abandoned this revision.Mar 9 2018, 7:55 PM

With the changes in https://phabricator.kde.org/D10376 this patch is not needed.

Revision Contents
Changeset List

PathPackages
Msrc/lib/jobs/kjob.cpp (7 lines)

Diff 27444

View Options

src/lib/jobs/kjob.cpp

Loading...