Separating sorting in ascending and descending order(faux SoK)

Authored by rohitdas on Jan 13 2018, 8:05 AM.



Applied only to ascending order activity for now.

Diff Detail

R2 GCompris
Lint Skipped
Unit Tests Skipped
rohitdas created this revision.Jan 13 2018, 8:05 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 13 2018, 8:05 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
rohitdas requested review of this revision.Jan 13 2018, 8:05 AM

It's too complicated to have the complete full diff.
To ease this, I'll create a branch with the latest code from the Github. Then I'll apply, and we will be able to start from a clean base.

Regarding the choice between ascending/descending, I've though more about it and I'm going to change my mind (sorry). Having an option in the configuration is not the best way to deal with it (children won't take a look).
It would be better to have a choice when starting the activity. I'm not sure which way is the best between all the potential sorting (numbers/letters...) and having a menu like in lang or having separate activities + a "simple" choice when starting the activity between "Ascending" and "Descending".

Ok. Let me know when you decide about it.

I merged in ascending_order branch to continue the work.
So first diff would be to recreate a new diff from from the branch to only have your changes.

You can also apply on this diff the required changes from Dec 9 2017, 5:43 PM:
(There are the comments made on May 16 on github ( to fix.
Can you also update the qml import to use the same as the other activities and adding in the ActivityInfo.qml the translator helpers (like in

Then, regarding the decision, it's better to have a discussion (you can start one by mail with the different propositions, advantages and drawbacks...).
For me, we should not have too much configuration to play the activity (type of activity + ascending/descending + categories corresponding to the min/max numbers).
For type of activity (numbers/letters/weights...), it can be done by doing separate activities. Then for ascending/descending + categories, it's too be discussed on how to do them.

Ok. Should I abandon this revision and create a new one without the config option and only with the hints? Then we can easily apply changes after considering various proposals on what you are proposing.

Yes, please :).
You can also abandon once you have taken in account the comments in the new diff.
Thank you

rohitdas abandoned this revision.Jan 18 2018, 8:52 AM

I have applied all the changes in the diff you mentioned. Abandoning revision.