[Task Manager] Reverse DBus setup order
ClosedPublic

Authored by broulik on Jan 12 2018, 9:36 AM.

Details

Summary

First connect to the signal, then register the object, and only at last register the service.
Otherwise it might expose a not yet fully operational service on DBus.

Test Plan

I made an app that listens for Unity service to be registered and send its badge info once it's there. Without this it would fire the signal before we connected to it resulting in the badge not showing on Plasma startup, with this patch it works.
iirc this is also what Thiago always said you should do when he did the threaded dbus changes in Qt 5.6

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 12 2018, 9:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2018, 9:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 12 2018, 9:36 AM
davidedmundson accepted this revision.Jan 12 2018, 11:48 AM
This revision is now accepted and ready to land.Jan 12 2018, 11:48 AM
This revision was automatically updated to reflect the committed changes.