| mart |
| Kirigami | |
| Discover Software Store |
The simple QML based Icon already provides this correctly, but DesktopIcon would not output in the correct location and aspect ratio, and rather draw the image scaled into the entirety of the node rectangle.
This fixes the issue described in https://bugs.kde.org/show_bug.cgi?id=388737
Without this patch, Discover shows items as seen in the attachment on the bug
With this patch, the output is as expected (with the correct aspect ratio and centered in the item)
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
+1 tested, seems to work for me, bug seems fixed.
Remember to add the BUG: 388737 tag in the commit message!
You are my hero. Awesome
When you have a really long or wide image will it be croped?
