[KFileItem] Use "emblem-shared" for shared files
ClosedPublic

Authored by broulik on Jan 11 2018, 11:13 AM.

Details

Summary

"network-workgroup" might work at 16px size but it's semantically incorrect and when rendered at larger size it turns into a folder and isn't suitable as an overlay.

Test Plan

The icon doesn't actually exist yet, there's emblem-shared-symbolic but I didn't want to explicitly mention a symbolic icon as none of the other emblems did. I requested one (basically just a symlink to the other) in Bug 388802

Before


After

I'm also fine with an all new icon, Andreas?

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 11 2018, 11:13 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 11 2018, 11:13 AM
broulik requested review of this revision.Jan 11 2018, 11:13 AM
apol added a subscriber: apol.Jan 11 2018, 2:45 PM

+1, definitely a step forward, although it seems a bit weird that a shared emblem and action is the same icon, no?

add an real emblem-shared icon cause the existing one was a symbolic one for gnome. should work now so +1


Andreas added an "emblem-shared" icon

andreaska accepted this revision.Jan 12 2018, 12:33 PM
This revision is now accepted and ready to land.Jan 12 2018, 12:33 PM
apol accepted this revision.Jan 12 2018, 12:46 PM
This revision was automatically updated to reflect the committed changes.