Details

Reviewers

astippich

Group Reviewers

Elisa

Maniphest Tasks

T7671: Explore unifying and factoring all the views

Commits

R255:d9f07791fcd5: introduce GridBrowserView and GridBrowserDelegate for generic grid view

Summary

add support for more roles in the model to allow generic delegates

provides roles that will be useable by the generic delegates

allow to retrieve the album or the artist with a generic role from models

support everything except open with generic view and delegate

allow all artsist and all albums models to know each other

this is needed to allow the models to generate proxy models linked to an
artist from an album item for example

makes it possible to open and use album or all albums from an artist views

still some things are not working well like the possibility to show the
artist of an album

I still need to report in the new components all the improvements that have gone since I started this branch

Test Plan

works fine

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Jan 10 2018, 6:27 AM

mgallien created this revision.

remove the old views and delegate
really remove old views and delegates
allows artist model to return a filtered model by a given artist name
mostly put back all actions in the different views

still some bugs (can push too much views when using "show artist" button

still need to update the grid view and the grid delegate after all the changes in master branch

remove the old views and delegate
really remove old views and delegates
allows artist model to return a filtered model by a given artist name
mostly put back all actions in the different views
rebase the delegate on the previous MediaAlbumDelegate component

rebase on master branch

rename two FontMetrics objects such their name are matching the changes
integrate the correct keyboard navigation
fix focus being lost after we switch to another view

fix small problems when testing

fix navigation to artist
ensure we replace the artist view only when needed

now I need to fix the missing data in NavigationActionBar

fix missing data in all NavigationActionBar
allow to show one or two lines of text in delegates of GridBrowserView

this is now finished and ready for review

mgallien retitled this revision from [WIP] introduce GridBrowserView and GridBrowserDelegate for generic grid view to introduce GridBrowserView and GridBrowserDelegate for generic grid view.Jan 11 2018, 8:48 PM

mgallien edited the test plan for this revision. (Show Details)

mgallien added a task: T7671: Explore unifying and factoring all the views.Jan 12 2018, 11:36 AM

mgallien added a project: Elisa.

works just fine

This revision is now accepted and ready to land.Jan 14 2018, 2:26 PM

Closed by commit R255:d9f07791fcd5: introduce GridBrowserView and GridBrowserDelegate for generic grid view (authored by mgallien). · Explain WhyJan 14 2018, 8:22 PM

This revision was automatically updated to reflect the committed changes.

astippich mentioned this in D9952: harmonize handling for all content delegates.Jan 17 2018, 7:25 PM

astippich mentioned this in R255:cf95542fb5de: harmonize handling for all content delegates.Jan 17 2018, 9:35 PM

		Path
M		autotests/CMakeLists.txt (1 line)
M		src/CMakeLists.txt (7 lines)
V		src/{GridBrowserDelegate.qml ← MediaArtistDelegate.qml} (125 lines)
A	M	src/GridBrowserView.qml (171 lines)
D	M	src/MediaAlbumDelegate.qml (318 lines)
M		src/MediaAlbumView.qml (67 lines)
D	M	src/MediaAllAlbumView.qml (144 lines)
D	M	src/MediaAllArtistView.qml (154 lines)
D	M	src/MediaArtistAlbumView.qml (164 lines)
V		src/{MediaArtistDelegate.qml → GridBrowserDelegate.qml}
M		src/MediaBrowser.qml (4 lines)
M		src/MediaServer.qml (154 lines)
M		src/NavigationActionBar.qml (53 lines)
M		src/albumfilterproxymodel.cpp (1 line)
M		src/albummodel.h (17 lines)
M		src/albummodel.cpp (77 lines)
M		src/allalbumsmodel.h (19 lines)
M		src/allalbumsmodel.cpp (61 lines)
M		src/allartistsmodel.h (22 lines)
M		src/allartistsmodel.cpp (69 lines)
M		src/alltracksmodel.h (3 lines)
M		src/alltracksmodel.cpp (43 lines)
M		src/mediaplaylist.h (3 lines)
M		src/mediaplaylist.cpp (59 lines)
M		src/upnpControl.qrc (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25051	b471e03		Jan 10 2018, 6:27 AM	★	★
Diff 2	25127	b471e03	- remove the old views and delegate	Jan 10 2018, 9:20 PM	★	★
Diff 3	25129	1d1e1be	- remove the old views and delegate	Jan 10 2018, 9:53 PM	★	★
Diff 4	25130	1d1e1be	- rename two FontMetrics objects such their name are matching the changes	Jan 10 2018, 10:04 PM	★	★
Diff 5	25173	1d1e1be	- fix navigation to artist	Jan 11 2018, 4:30 PM	★	★
Diff 6	25185	1d1e1be	- fix missing data in all NavigationActionBar	Jan 11 2018, 8:48 PM	★	★
Diff 7	25344	e09db80	R255:d9f07791fcd519b875744326302da4f7be73648c	Jan 14 2018, 8:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
80d3e7b62360	9739df02b1f1	d484c4cabe65	Matthieu Gallien	allow to show one or two lines of text in delegates of GridBrowserView	Jan 11 2018, 8:44 PM
d484c4cabe65	d38be5e4d925	8fc03fcb8bc2	Matthieu Gallien	fix missing data in all NavigationActionBar	Jan 11 2018, 4:57 PM
8fc03fcb8bc2	934540d3267a	062ae09188a8	Matthieu Gallien	ensure we replace the artist view only when needed	Jan 11 2018, 4:27 PM
062ae09188a8	8a496878defc	de2af17d5151	Matthieu Gallien	fix navigation to artist (Show More…)	Jan 11 2018, 6:39 AM
de2af17d5151	0d13cfe6c0ee	7e1a6f4fbd46	Matthieu Gallien	fix focus being lost after we switch to another view	Jan 10 2018, 10:03 PM
7e1a6f4fbd46	4e684dc0ff45	4039193c2af6	Matthieu Gallien	integrate the correct keyboard navigation	Jan 10 2018, 9:59 PM
4039193c2af6	df8632da5e55	208da20d9e48	Matthieu Gallien	rename two FontMetrics objects such their name are matching the changes	Jan 10 2018, 9:55 PM
208da20d9e48	6ba0d07fe27f	2406082d31f0	Matthieu Gallien	rebase the delegate on the previous MediaAlbumDelegate component	Jan 10 2018, 9:52 PM
2406082d31f0	7afffdc6e8d8	aa62b5e3f232	Matthieu Gallien	mostly put back all actions in the different views	Jan 10 2018, 9:18 PM
aa62b5e3f232	711cfbda61ad	ddd73de11eb4	Matthieu Gallien	allows artist model to return a filtered model by a given artist name	Jan 10 2018, 8:00 PM
ddd73de11eb4	acebd2364ec1	677b36321698	Matthieu Gallien	really remove old views and delegates	Jan 10 2018, 7:46 PM
677b36321698	6edff70aa7ba	c1f619dddd6a	Matthieu Gallien	remove the old views and delegate	Jan 10 2018, 4:57 PM
c1f619dddd6a	b7b83b8031bb	42adaccb32db	Matthieu Gallien	[WIP] introduce GridBrowserView and GridBrowserDelegate for generic grid view (Show More…)	Jan 10 2018, 6:19 AM
42adaccb32db	33fc7e5c8e24	cd2882bddb8c	Matthieu Gallien	allow all artsist and all albums models to know each other (Show More…)	Jan 8 2018, 10:20 PM
cd2882bddb8c	312c958bdcba	92d0186ee530	Matthieu Gallien	support everything except open with generic view and delegate	Jan 3 2018, 10:11 PM
92d0186ee530	9c879751effd	283c3d7aed1a	Matthieu Gallien	allow to retrieve the album or the artist with a generic role from models	Jan 3 2018, 10:09 PM
283c3d7aed1a	55c4be5416aa	617fb4f85999	Matthieu Gallien	add support for more roles in the model to allow generic delegates (Show More…)	Jan 3 2018, 8:58 PM
617fb4f85999	c588f6e53e0f	1d1e1be79d74	Matthieu Gallien	introduce GridBrowserView and GridBrowserDelegate for generic grid view	Jan 3 2018, 12:32 PM

introduce GridBrowserView and GridBrowserDelegate for generic grid view
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 25344

autotests/CMakeLists.txt

src/CMakeLists.txt

src/GridBrowserDelegate.qml

src/GridBrowserView.qml

src/MediaAlbumDelegate.qml

src/MediaAlbumView.qml

src/MediaAllAlbumView.qml

src/MediaAllArtistView.qml

src/MediaArtistAlbumView.qml

src/MediaArtistDelegate.qml

src/MediaBrowser.qml

src/MediaServer.qml

src/NavigationActionBar.qml

src/albumfilterproxymodel.cpp

src/albummodel.h

src/albummodel.cpp

src/allalbumsmodel.h

src/allalbumsmodel.cpp

src/allartistsmodel.h

src/allartistsmodel.cpp

src/alltracksmodel.h

src/alltracksmodel.cpp

src/mediaplaylist.h

src/mediaplaylist.cpp

src/upnpControl.qrc

introduce GridBrowserView and GridBrowserDelegate for generic grid viewClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 25344

autotests/CMakeLists.txt

src/CMakeLists.txt

src/GridBrowserDelegate.qml

src/GridBrowserView.qml

src/MediaAlbumDelegate.qml

src/MediaAlbumView.qml

src/MediaAllAlbumView.qml

src/MediaAllArtistView.qml

src/MediaArtistAlbumView.qml

src/MediaArtistDelegate.qml

src/MediaBrowser.qml

src/MediaServer.qml

src/NavigationActionBar.qml

src/albumfilterproxymodel.cpp

src/albummodel.h

src/albummodel.cpp

src/allalbumsmodel.h

src/allalbumsmodel.cpp

src/allartistsmodel.h

src/allartistsmodel.cpp

src/alltracksmodel.h

src/alltracksmodel.cpp

src/mediaplaylist.h

src/mediaplaylist.cpp

src/upnpControl.qrc

introduce GridBrowserView and GridBrowserDelegate for generic grid view
ClosedPublic
Actions

Revision Contents
Changeset List