Differential D9768

Cache KColorScheme instances
ClosedPublic
Actions

Authored by apol on Jan 9 2018, 4:46 PM.

Details

Reviewers
mart
Group Reviewers
Frameworks
Commits
R858:89760fddd4cb: Cache KColorScheme instances
Summary

This patch catches the few different KColorScheme we use so that every
widget can access the same instead of computing it separately.
As is, the different KColorScheme were initialised really often for every
widget that specifies a colorSet.

Test Plan

Used it with Discover and Kirigami Gallery

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jan 9 2018, 4:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 9 2018, 4:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jan 9 2018, 4:46 PM
mart accepted this revision.Jan 9 2018, 4:52 PM
This revision is now accepted and ready to land.Jan 9 2018, 4:52 PM
Closed by commit R858:89760fddd4cb: Cache KColorScheme instances (authored by apol). · Explain WhyJan 9 2018, 4:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25031

View Options

kirigami-plasmadesktop-integration/plasmadesktoptheme.h

Loading...
View Options

kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp

Loading...