Mining for gold: Fix layout for vertical mode
ClosedPublic

Authored by ganeshredcobra on Jan 9 2018, 11:53 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris
Maniphest Tasks
T7611: Mining for gold: Fix layout for vertical mode
Summary

Moved the Score icon to top of the bar
Reduced the size of the score icon so that nuggets coming near the icon is not missed

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
ganeshredcobra created this revision.Jan 9 2018, 11:53 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 9 2018, 11:53 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript

@ganeshredcobra can you please check that no nuggets are generated on the bar.top (i.e. the place where you have shifted score) as in https://cdn.pbrd.co/images/H295Xjn.png I was able to find a nugget just at the same place.

@ganeshredcobra can you please check that no nuggets are generated on the bar.top (i.e. the place where you have shifted score) as in https://cdn.pbrd.co/images/H295Xjn.png I was able to find a nugget just at the same place.

@asagtani The size of the score image is reduced so none of the nuggets or stars are obstructed. I am uploading some images for proof.

The difference between old and new versions when start is there

https://pasteboard.co/H2ieY9i.png

when it becomes nugget

https://pasteboard.co/H2if8Qr.png

It's great if it doesn't overlap with any nuggets or stars.
One more thing, for horizontal screens https://cdn.pbrd.co/images/H2j865o.png isn't it too small. How about changing the size and position in case of vertical screens only and the keep present configuration for the horizontal screen. What do you say?

ganeshredcobra updated this revision to Diff 25480.EditedJan 16 2018, 3:40 PM

The Score icon size and position changes dynamically for Vertical and Horizontal Mode.

Vertical Mode - Reduced Icon size and on top of bar

https://pasteboard.co/H3cXtJV.png

Horizontal Mode - Icon size increased and position changed to bottom right

https://pasteboard.co/H3cXE7b.png

Tested. Change works well, carriage size is changing when horizontal size smaller than vertical, and placed at the right place.
Validated for me.

jjazeix accepted this revision.Jan 24 2018, 7:21 AM
This revision is now accepted and ready to land.Jan 24 2018, 7:21 AM