Differential D9750

ExpandingWidgetModel: find the right-most column based on location
ClosedPublic
Actions

Authored by mwolff on Jan 8 2018, 11:23 PM.

Details

Reviewers
None
Group Reviewers
Kate
Commits
R39:7c648c89ed11: ExpandingWidgetModel: find the right-most column based on location
Summary

This fixes the width calculation for the argument hint completion
items. There, the view apparently reorders the column, or hides
some, and thus the last sibling by column number is not actually
the right-most one. In truth, the old algorithm even produced
negative widget values, which prevented the argument hint widgets
from ever being shown. This patch fixes that.

Note: You'll probably need KDevelop to see the effect.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Jan 8 2018, 11:23 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 8 2018, 11:23 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mwolff requested review of this revision.Jan 8 2018, 11:23 PM
kfunk added a subscriber: kfunk.Jan 9 2018, 8:21 AM

LGTM, but I'll let someone else approve.

cullmann added a subscriber: cullmann.Jan 9 2018, 8:22 AM

;=) I assume then a KDevelop person must try it.

mwolff added a comment.Jan 9 2018, 9:55 AM

I'll push it then

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2018, 10:00 AM
Closed by commit R39:7c648c89ed11: ExpandingWidgetModel: find the right-most column based on location (authored by mwolff). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24993

View Options

src/completion/expandingtree/expandingwidgetmodel.cpp

Loading...