Differential D9643

Support submenus in context menu for systray icon
ClosedPublic
Actions

Authored by volkov on Jan 3 2018, 4:48 PM.

Details

Reviewers
graesslin
davidedmundson
Group Reviewers
Plasma
Commits
R135:f2275d4440a6: Support submenus in context menu for systray icon

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
volkov created this revision.Jan 3 2018, 4:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2018, 4:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
volkov requested review of this revision.Jan 3 2018, 4:48 PM
volkov added a comment.Jan 3 2018, 4:53 PM

BTW, why do we need to support KDEPlatformSystemTrayIcon? Why don't rely on QDBusTrayIcon?

davidedmundson added a subscriber: davidedmundson.Jan 3 2018, 5:45 PM

Why don't rely on QDBusTrayIcon?

It's internal to Qt.

We could fork it like we did with the application menu, but then that's no easier than maintaining our current code.

davidedmundson added a comment.Jan 3 2018, 5:50 PM

Please fill in the "testing done" field.

broulik added a subscriber: broulik.Jan 5 2018, 11:28 AM

+1

I can verify that it makes VLC player's "Speed" sub menu in its tray icon work, checked that Qt's code is identical.

davidedmundson accepted this revision.Jan 5 2018, 11:29 AM
This revision is now accepted and ready to land.Jan 5 2018, 11:29 AM
volkov added a comment.Jan 8 2018, 12:17 PM

Thanks for the real-world example.

volkov closed this revision.Jan 8 2018, 12:17 PM

Revision Contents
Changeset List

Diff 24678

View Options

src/platformtheme/kdeplatformsystemtrayicon.h

Loading...
View Options

src/platformtheme/kdeplatformsystemtrayicon.cpp

Loading...