[DBusMenuImporter] Send "opened" signal alongside about to show
ClosedPublic
Actions

Authored by broulik on Jan 3 2018, 9:13 AM.

Details

Reviewers

davidedmundson
fvogt

Group Reviewers

Plasma

Commits

R120:b711b7073fd5: [DBusMenuImporter] Send "opened" signal alongside about to show

Summary

Firefox deliberately ignores the "about-to-show" event and only updates its menus in response to "opened".
There was an unused slot to send an "opened" event. Use that and place the updateMenu call inside.
Also use an UniqueConnection.

Test Plan

Firefox window decoration menu buttons seem to work mostly fine now. Didn't notice any issues with other already working apps. If someone could test whether Electron apps still behave well with it. Global menu applet needs an additional patch for Firefox to work correctly with it.

https://bazaar.launchpad.net/~mozillateam/firefox/firefox-trunk.head/view/head:/debian/patches/unity-menubar.patch#L955

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Jan 3 2018, 9:13 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2018, 9:13 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jan 3 2018, 9:13 AM

broulik edited the test plan for this revision. (Show Details)Jan 3 2018, 9:18 AM

davidedmundson added inline comments.Jan 3 2018, 9:58 AM

libdbusmenuqt/dbusmenuimporter.cpp
433–434	This needs to be a unique connection see https://phabricator.kde.org/D5706 (which might mean moving updateMenu into slotMenuAboutToShow)

broulik edited the summary of this revision. (Show Details)Jan 3 2018, 11:10 AM

broulik edited the test plan for this revision. (Show Details)

broulik updated this revision to Diff 24657.Jan 3 2018, 11:16 AM

davidedmundson accepted this revision.Jan 4 2018, 6:52 PM

This revision is now accepted and ready to land.Jan 4 2018, 6:52 PM

Closed by commit R120:b711b7073fd5: [DBusMenuImporter] Send "opened" signal alongside about to show (authored by broulik). · Explain WhyJan 5 2018, 9:09 AM

This revision was automatically updated to reflect the committed changes.

broulik mentioned this in D9782: [DBusMenuImporter] Just send "opened" in updateMenu().Jan 10 2018, 9:52 AM

Revision Contents
Changeset List

			Path	Packages
M			libdbusmenuqt/dbusmenuimporter.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24649			Jan 3 2018, 9:09 AM	★	★
Diff 2	24657			Jan 3 2018, 11:16 AM	★	★
Diff 3	24757	59ba8b8	R120:b711b7073fd53e683db9a9bee75db5290495563f	Jan 5 2018, 9:09 AM	★	★

Diff 24757

View Options

libdbusmenuqt/dbusmenuimporter.cpp