Differential D9782

[DBusMenuImporter] Just send "opened" in updateMenu()
ClosedPublic
Actions

Authored by broulik on Jan 10 2018, 9:52 AM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Plasma
Commits
R120:755adc801aa1: [DBusMenuImporter] Just send "opened" in updateMenu()
Summary

We call updateMenu() to cache the first level of menus in advance in global menu applet.
Just move the "opened" call there to ensure it's always called both when the menu shows or when someone manually triggers it.

Test Plan

I have working menus in Firefox now \o/
Other apps and tray icons seem unaffected

Follow up to D9631 which wasnt sufficient

I checked Qt code, it doesn't do anything with "opened" signal

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 10 2018, 9:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 10 2018, 9:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 10 2018, 9:52 AM
mart accepted this revision.Jan 12 2018, 3:37 PM
This revision is now accepted and ready to land.Jan 12 2018, 3:37 PM
Closed by commit R120:755adc801aa1: [DBusMenuImporter] Just send "opened" in updateMenu() (authored by broulik). · Explain WhyJan 15 2018, 9:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibdbusmenuqt/dbusmenuimporter.cpp (9 lines)

Diff 25376

View Options

libdbusmenuqt/dbusmenuimporter.cpp

Loading...