Differential D9621

Restrict access modifiers to the necessary
ClosedPublic
Actions

Authored by nicolasfella on Jan 2 2018, 9:44 PM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R225:22696f7c9788: Restrict access modifiers to the necessary
Summary

Set access to (package) private where possible
Depends on D9620

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
arcpatch-D9621_3
Lint
No Linters Available
Unit
No Unit Test Coverage
nicolasfella requested review of this revision.Jan 2 2018, 9:44 PM
nicolasfella created this revision.
nicolasfella edited the summary of this revision. (Show Details)Jan 2 2018, 9:45 PM
nicolasfella added a project: KDE Connect.
nicolasfella added a dependency: D9620: Remove dead code.
mtijink added a subscriber: mtijink.Jan 3 2018, 7:25 PM
mtijink added inline comments.
src/org/kde/kdeconnect/Plugins/NotificationsPlugin/RepliableNotification.java
11 ↗(On Diff #24631)

Why does the id need to remain public?

nicolasfella updated this revision to Diff 24690.Jan 3 2018, 8:02 PM

Make id package private

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/RepliableNotification.java
11 ↗(On Diff #24631)

It doesn't. No idea why Android Studio didn't tell me that

mtijink accepted this revision.Jan 3 2018, 8:03 PM
This revision is now accepted and ready to land.Jan 3 2018, 8:03 PM
Closed by commit R225:22696f7c9788: Restrict access modifiers to the necessary (authored by nicolasfella). · Explain WhyJan 3 2018, 8:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24690

View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/RepliableNotification.java

Loading...