Differential D9589

Unexport kjscmd
ClosedPublic
Actions

Authored by vkrause on Jan 1 2018, 1:51 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R315:576d0eec01ef: Unexport kjscmd
Summary

This is a user tool, not a build-time tool. Having it exported makes it
required to be available (and runnable) for the corresponding find_package
call to work, which is by default not the case when cross-compiling.

Diff Detail

Repository
R315 KJsEmbed
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jan 1 2018, 1:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 1 2018, 1:51 PM
vkrause requested review of this revision.Jan 1 2018, 1:51 PM
bshah added a subscriber: bshah.Jan 27 2018, 1:27 PM
bshah added inline comments.
src/kjscmd/CMakeLists.txt
6

:-P

vkrause added inline comments.Jan 27 2018, 1:41 PM
src/kjscmd/CMakeLists.txt
6

That suggests it shouldn't even be installed in the first place? Would fix the cross-compilation issue too.

bshah added inline comments.Jan 27 2018, 1:54 PM
src/kjscmd/CMakeLists.txt
6

I am not sure tbh, question is what it does and what does it mean by developer tool?

  • KJSEmbed framework developer?
  • 3rd-party developer?

If it's 3rd party, it should be installed IMO, but well who knows.. I am not even sure I understand what this tool does..

apol accepted this revision.Jan 27 2018, 2:47 PM
This revision is now accepted and ready to land.Jan 27 2018, 2:47 PM
Closed by commit R315:576d0eec01ef: Unexport kjscmd (authored by vkrause). · Explain WhyJan 27 2018, 7:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kjscmd/CMakeLists.txt (2 lines)

Diff 26085

View Options

src/kjscmd/CMakeLists.txt

Loading...