Differential D9546

Per Plugin minSdk Level
ClosedPublic
Actions

Authored by nicolasfella on Dec 29 2017, 2:14 PM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R225:c9ca1f4906fc: Per Plugin minSdk Level
Summary

Each plugin gets a minSdk level assigned. If this level isn't available the plugin doesn't get loaded. This can simplifie the plugin code by removing reccuring Sdk version checks.
Should we let the user know that a plugin is not available due to that or should it fail silently?

Actual Plugin adaptions come in follow-up patches.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Dec 29 2017, 2:14 PM
nicolasfella created this revision.
mtijink accepted this revision.Dec 30 2017, 11:21 AM
mtijink added a subscriber: mtijink.

Looks good to me.

This revision is now accepted and ready to land.Dec 30 2017, 11:21 AM
Closed by commit R225:c9ca1f4906fc: Per Plugin minSdk Level (authored by nicolasfella). · Explain WhyJan 3 2018, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24686

View Options

src/org/kde/kdeconnect/Device.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/Plugin.java

Loading...