T7609:Click on me: fix layout for vertical screens
ClosedPublic

Authored by ganeshredcobra on Dec 26 2017, 5:09 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris
Maniphest Tasks
T7609: Click on me: fix layout for vertical screens
Summary

Click on me: fix layout for vertical screens

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
ganeshredcobra created this revision.Dec 26 2017, 5:09 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 26 2017, 5:09 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
ganeshredcobra requested review of this revision.Dec 26 2017, 5:09 PM

@ganeshredcobra At bar.top fishes will be hidden behind Score box https://pasteboard.co/H3teZ3x.png.
Fishes are generated at random y coordinates (https://github.com/gcompris/GCompris-qt/blob/master/src/activities/clickgame/clickgame.js#L288).
Repositioning score box to top right corner and make changes in code such that fishes are generated between score.bottom and bar.top can be a good solution. What do you say?

Repositioned the score box to top right corner and made changes in code such that fishes are generated between score.bottom and bar.top

jjazeix added inline comments.
src/activities/clickgame/Clickgame.qml
74–75

indentation

jjazeix added a comment.EditedJan 31 2018, 11:22 AM

You only changed the y at creation, not when the fish turns, can you also handle it (it's in Fish.qml)?

Indentation corrected

ganeshredcobra marked an inline comment as done.Jan 31 2018, 5:38 PM

You only changed the y at creation, not when the fish turns, can you also handle it (it's in Fish.qml)?

Yes i will do that

Handled y position when the fish turns.

This revision is now accepted and ready to land.Feb 10 2018, 3:40 PM
jjazeix closed this revision.Feb 10 2018, 3:42 PM