Click on me: fix layout for vertical screens
Details
- Reviewers
jjazeix - Group Reviewers
GCompris - Maniphest Tasks
- T7609: Click on me: fix layout for vertical screens
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
@ganeshredcobra At bar.top fishes will be hidden behind Score box https://pasteboard.co/H3teZ3x.png.
Fishes are generated at random y coordinates (https://github.com/gcompris/GCompris-qt/blob/master/src/activities/clickgame/clickgame.js#L288).
Repositioning score box to top right corner and make changes in code such that fishes are generated between score.bottom and bar.top can be a good solution. What do you say?
Repositioned the score box to top right corner and made changes in code such that fishes are generated between score.bottom and bar.top
src/activities/clickgame/Clickgame.qml | ||
---|---|---|
74–75 | indentation |
You only changed the y at creation, not when the fish turns, can you also handle it (it's in Fish.qml)?
Committed in https://cgit.kde.org/gcompris.git/commit/?id=1df9ddf5a6a976e884e59eeb628f666b0f13414a (with small coding rules changes)