Differential D9493

Highlighting indexer: Warn about context switch fallthroughContext="#stay"
ClosedPublic
Actions

Authored by dhaumann on Dec 23 2017, 9:06 PM.

Details

Reviewers
vkrause
cullmann
Commits
R216:79ca6ce4ec6a: Highlighting indexer: Warn about context switch fallthroughContext="#stay"
Summary

A fallthroughContext="#stay" is always wrong if fallthrough="true" is set,
since in this case we risk an infinite loop. This patch extends the indexer
to check for this mistakes. Luckily, this mistake does not exist in the
definition files shipped with the KSyntaxHighlighting framework.

Test Plan

make test, manual testing with fallthroughContext="#stay"

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Dec 23 2017, 9:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 23 2017, 9:06 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 23 2017, 9:06 PM
vkrause accepted this revision.Dec 24 2017, 1:03 PM
This revision is now accepted and ready to land.Dec 24 2017, 1:03 PM
Closed by commit R216:79ca6ce4ec6a: Highlighting indexer: Warn about context switch fallthroughContext="#stay" (authored by dhaumann). · Explain WhyDec 24 2017, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24360

View Options

src/indexer/katehighlightingindexer.cpp

Loading...