Currently, slide effect doesn't handle a case when there
is a moving client. This results in having window jumps.
This commit fixes it by fixing position of the moving client
during switching to another desktop.
Details
Details
- Reviewers
graesslin - Group Reviewers
KWin Plasma - Commits
- R108:20780c6f2144: [effects/slide] Handle moving clients
- send window one desktop to the left/right using shortcuts
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| effects/slide/slide.cpp | ||
|---|---|---|
| 92–93 | I don't like empty if blocks. Please handle this e.g. with if (slide && w != m_movingWindow) | |
| 279 | The window is nowhere reset, also it's not handling the windowClosed/windowRemoved case. This means the pointer could dangle. | |
| effects/slide/slide.h | ||
| 68 | You can simplify: EffectWindow *m_movingWindow = nullptr; | |
| effects/slide/slide.cpp | ||
|---|---|---|
| 295–296 | coding style nitpick: please wrap in {} | |
Comment Actions
@zzag: do you have commit rights? If not please request a developer account. Please see https://community.kde.org/Infrastructure/Get_a_Developer_Account
Comment Actions
@graesslin No, I don't.
As stated in https://community.kde.org/Infrastructure/Get_a_Developer_Account
Also please apply for an account only if you think that you will work on KDE for a somewhat longer time. If you know that you will only work for a couple of weeks and then never again, please consider not applying for a KDE Developer account but instead continue to send patches directly to developers.
It would be better not to apply for a KDE developer account.
Comment Actions
I'm not able to apply it with arc patch. It complains about a missing base commit and tries to download from github which I don't use.
Comment Actions
Hmm, weird.. I've just applied for a developer account. If I get commit rights, I will land them.
Happy holidays! :)