[libkwineffects] Delete deprecated 'desktopChanged(int,int)' signal
AbandonedPublic
Actions

Authored by zzag on Dec 23 2017, 10:17 AM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Summary

EffectsHandler::desktopChanged(int,int) was deprecated by
commit a332bf183bdcad2bf1f1f4df06eff750c9e8ce1c in 2012.

Diff Detail

Repository

R108 KWin

Branch

libkwineffect/delete-deprecated-desktopchanged

Lint

No Linters Available

Unit

No Unit Test Coverage

zzag created this revision.Dec 23 2017, 10:17 AM

Restricted Application added a project: KWin. · View Herald TranscriptDec 23 2017, 10:17 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Dec 23 2017, 10:17 AM

zzag added a dependent revision: D9487: [effects/slide] Handle moving clients.Dec 23 2017, 10:20 AM

zzag added a reviewer: Plasma.Dec 23 2017, 10:24 AM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 23 2017, 10:24 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This would break also existing third party effects. Thus we cannot remove it and that was the reason why it was not removed. We have to keep it till we decide to break the API of effects. This won't happen in the 5.x time frame.

This revision now requires changes to proceed.Dec 23 2017, 2:39 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptDec 23 2017, 2:39 PM

zzag abandoned this revision.Dec 24 2017, 6:25 AM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 24 2017, 6:25 AM

Revision Contents
Changeset List

			Path	Packages
M			effects.cpp (2 lines)
M			effects/cube/cubeslide.h (2 lines)
M			effects/cube/cubeslide.cpp (4 lines)
M			effects/dialogparent/package/contents/code/main.js (2 lines)
M			effects/fadedesktop/package/contents/code/main.js (2 lines)
M			effects/frozenapp/package/contents/code/main.js (2 lines)
M			effects/slide/slide.h (2 lines)
M			effects/slide/slide.cpp (5 lines)
M			effects/translucency/package/contents/code/main.js (2 lines)
M			libkwineffects/kwineffects.h (7 lines)

Commit	Tree	Parents	Author	Summary	Date
e17480bb4add	b85d9191c02f	00d45a1fb0ff	Vlad Zagorodniy	[libkwineffects] Delete deprecated 'desktopChanged(int,int)' signal (Show More…)	Dec 23 2017, 8:02 AM