Differential D9479

[widgetexplorer] Fix trying to show deleted dialog
ClosedPublic
Actions

Authored by anthonyfieroni on Dec 22 2017, 2:06 PM.

Details

Reviewers
fvogt
davidedmundson
Group Reviewers
Plasma
Commits
R120:acd7034952bc: [widgetexplorer] Fix trying to show deleted dialog
Summary

WidgetExplorer is destroyed on close which deletes KNS dialog.

Test Plan

Manually test, verify it.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Dec 22 2017, 2:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 22 2017, 2:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Dec 22 2017, 2:06 PM
fvogt added a comment.Dec 22 2017, 2:08 PM

IMO you can delete the empty destructor now.

anthonyfieroni updated this revision to Diff 24297.Dec 22 2017, 2:11 PM

Remove entire destructor.

davidedmundson accepted this revision.Dec 22 2017, 2:18 PM
This revision is now accepted and ready to land.Dec 22 2017, 2:18 PM
Closed by commit R120:acd7034952bc: [widgetexplorer] Fix trying to show deleted dialog (authored by anthonyfieroni). · Explain WhyDec 22 2017, 2:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24298

View Options

components/shellprivate/widgetexplorer/widgetexplorer.cpp

Loading...