| davidedmundson | |
| anthonyfieroni |
| Plasma |
This reverts commit 84a29ef86380fab40236bdf934b49bc3cf090853.
WidgetExplorer gets destroyed immediately the containment is closed, so
the dialog is immediately deleted. The bug the patch was supposed to fix
is totally unrelated to this, as according to the report a restart of
plasmashell does not help.
Not tested, but setting a breakpoint on the dialog's destructor
points to this change.
| No Linters Available |
| No Unit Test Coverage |
Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working.
Deletion is needed
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$50
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$69
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$121
https://phabricator.kde.org/source/knewstuff/browse/master/src/core/engine.cpp;6de0754aa9258558a7203afc366b49984f0192eb$107
Save this cache to disk, otherwise not saving anything since dialog just leak.
"Download new widgets" -> Either plasmashell crashes instantly or the dialog does not show up and plasmashell crashes on the next click.
Then the dialog should be destroyed on close or KNS3 needs to save the cache more often.
| components/shellprivate/widgetexplorer/widgetexplorer.cpp | ||
|---|---|---|
| 448 | what's the situation with this line? | |
| components/shellprivate/widgetexplorer/widgetexplorer.cpp | ||
|---|---|---|
| 448 | Such a slot not existing at all. | |
| components/shellprivate/widgetexplorer/widgetexplorer.cpp | ||
|---|---|---|
| 448 | Even more WidgetExplorer is closed upon DownloadDialog is shown, which makes such slot useless. But now it can be opened more than one DownloadDialogs and it looks strange. | |