Differential D9441

Fix PlacesItemModel loading with hidden devices
ClosedPublic
Actions

Authored by renatoo on Dec 20 2017, 6:31 PM.

Details

Reviewers
franckarrecot
Commits
R318:94b2b2a2dbd3: Fix PlacesItemModel loading with hidden devices
Summary

Make sure that hidden devices loaded after module initialization does
not appear in the view.
Check for item visibility before add it on the model.

Test Plan

Unit test created

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
renatoo created this revision.Dec 20 2017, 6:31 PM
Restricted Application added a subscriber: Dolphin. · View Herald TranscriptDec 20 2017, 6:31 PM
renatoo requested review of this revision.Dec 20 2017, 6:31 PM
ervin added a subscriber: ervin.Dec 20 2017, 6:42 PM

I wonder if the test wouldn't be better inside addItemFromSourceModel? Other than that, looks good to me.

renatoo updated this revision to Diff 24182.Dec 20 2017, 6:53 PM

Check for hidden item in 'addItemFromSourceModel'

ervin added a comment.Dec 20 2017, 7:47 PM

Looks good to me. Waiting for the Dolphin people to look at it.

franckarrecot accepted this revision.Dec 21 2017, 8:48 AM
This revision is now accepted and ready to land.Dec 21 2017, 8:48 AM
cfeck added a subscriber: cfeck.Jan 8 2018, 2:41 AM

If this should be in 17.12.1, please commit today. If I understand it correctly, this is required to fix the unhideable duplicate Devices and Remote Devices in the places panel.

Closed by commit R318:94b2b2a2dbd3: Fix PlacesItemModel loading with hidden devices (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyJan 8 2018, 11:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24182

View Options

src/panels/places/placesitemmodel.cpp

Loading...
View Options

src/tests/placesitemmodeltest.cpp

Loading...