If a window manager doesn't position dialog windows, then
they are centered on a parent window by Qt.
DialogStateSaver::restoreWindowState() is called before
a layout is set for DialogBase and thus it resizes
DialogBase to (-1, -1) returned by DialogBase::sizeHint().
Qt centers the dialog with such size on its parent,
but the dialog changes its size in DialogBase::showEvent()
and becomes uncentered.
Setup the layout before DialogBase::showEvent() to fix it.
| No Linters Available |
| No Unit Test Coverage |
Another option is to emit a signal in DialogBase::showEvent() after setting the layout and process it in DialogStateSaver instead of filtering events.
Thanks volkov for your investigations and comments - this code that previously I've only used for my personal stuff, so it's good to have someone else look at it.
It's not mandated in the KDE coding style, but I'd prefer to stick to the existing style in this file and do explicit pointer checks against nullptr (see inline comments).
Assuming that you've tested this with KMix master then please commit (with changes as marked inline) - I can merge your changes and check that everything else works properly.
Regarding your last comment, the intention of filtering events in DialogStateSaver was that it could also be used for saving/restoring the size where the dialogue is not based on DialogBase - e.g. a QFontDialog or a KPageDialog. You haven't needed to make any changes to DialogStateSaver, though, so it will still work in these use cases.
| gui/dialogbase.cpp | ||
|---|---|---|
| 64 | w==nullptr | |
| 65 | !=nullptr | |
| 72 | !=nullptr | |
| 78 | Also needs the mMainLayout->setStretchFactor(mMainWidget, 1); here | |