[Login / Lock screen] Underline button when focussed
ClosedPublic

Authored by broulik on Dec 20 2017, 11:46 AM.

Details

Summary

This makes it obvious that pressing tab moves focus to the buttons.

Test Plan


Tabbed through login screen, saw that my Tab did something and triggered reboot by pressing Space or Return

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 20 2017, 11:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 20 2017, 11:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 20 2017, 11:46 AM
davidedmundson accepted this revision.Dec 20 2017, 11:47 AM
This revision is now accepted and ready to land.Dec 20 2017, 11:47 AM

Hover and focus should not have the same visual effect, otherwise a user can not distinguish them.

Either

  • show only an effect for focus
  • use two different effects, eg underline and highlight
  • handle it like a list and use the same highlight for focus and hover.

I'll probably just go with "underline on focus" and leave everything unchanged, ie. no highlight effect as (for some reason) we never had that before in the design.

broulik updated this revision to Diff 24208.Dec 21 2017, 11:29 AM
broulik retitled this revision from [Login / Lock screen] Highlight button when focus or hover to [Login / Lock screen] Underline button when focussed.
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Dec 21 2017, 11:49 AM
This revision was automatically updated to reflect the committed changes.