MessageInterface: Add CenterInView as additional position
ClosedPublic
Actions

Authored by dhaumann on Dec 18 2017, 10:50 AM.

Details

Reviewers

Commits

R39:fc7433321d36: MessageInterface: Add CenterInView as additional position

Summary

This patch extends the message interface to support CenterInView.
This should be binary compatible, since an enum is only added at
the end. In order to support this, a custom layout called
KateMessageLayout was added that only supports the floating
positions allowed by KTextEditor::Message::MessagePosition.

Upadte unit test, it seems the window size was too small for
the MessageTest.

Test Plan

make test

Diff Detail

Repository

R39 KTextEditor

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dhaumann created this revision.Dec 18 2017, 10:50 AM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 18 2017, 10:50 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

dhaumann requested review of this revision.Dec 18 2017, 10:50 AM

@cullmann This patch now only adds the CenterInView, nothing else (i.e. no changes in search code). Now good to go?

Add @since 5.42

Jup, ok ;)

The 5 as size is still bit strange, but as we have no end enum value, which we don't want to be BC, I guess that is no issue.

cullmann accepted this revision.Dec 18 2017, 11:03 AM

This revision is now accepted and ready to land.Dec 18 2017, 11:03 AM

Closed by commit R39:fc7433321d36: MessageInterface: Add CenterInView as additional position (authored by dhaumann). · Explain WhyDec 18 2017, 11:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/src/kateview_test.cpp (1 line)
M			src/include/ktexteditor/message.h (15 lines)
M			src/view/kateview.h (23 lines)
M			src/view/kateview.cpp (68 lines)
M			src/view/kateviewhelpers.h (39 lines)
M			src/view/kateviewhelpers.cpp (82 lines)
M			src/view/kateviewinternal.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24058	eb0bdd4		Dec 18 2017, 10:50 AM	★	★
Diff 2	24059	eb0bdd4	- Add @since 5.42	Dec 18 2017, 11:01 AM	★	★
Diff 3	24061	2e0e364	R39:fc7433321d364e7c14386ae2adb7607caf8108b1	Dec 18 2017, 11:03 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d5457417c336	112a9d3171d6	50b3f1a7cc49	Dominik Haumann	Add @since 5.42	Dec 18 2017, 11:01 AM
50b3f1a7cc49	3fc467b44989	f12e8a63d3a7	Dominik Haumann	MessageInterface: Add CenterInView as additional position (Show More…)	Dec 18 2017, 10:49 AM
f12e8a63d3a7	571ae9391545	eb0bdd49417c	Dominik Haumann	MessageInterface: Add CenterInView as additional position (Show More…)	Dec 18 2017, 10:44 AM