In D9386#181227, @dfaure wrote:

If this wasn't kdelibs4support, I'd insist for sharing the implementation rather than duplicating it.

Would be nice to share, but networking.cpp is only be used on non win32 platform, so how to share ?

if(WIN32)

set(libkdelibs4support_SRCS solid/networking_win.cpp
                            kdeui/kapplication_win.cpp)

else()

set(libkdelibs4support_SRCS solid/networking.cpp)

endif()

That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and move to networking.cpp the methods that are platform-independent.

In D9386#181297, @dfaure wrote:

That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and move to networking.cpp the methods that are platform-independent.

Any idea how to share the line

Q_GLOBAL_STATIC(Solid::NetworkingPrivate, globalNetworkManager)

between platform independent, unix and windows related file. globalNetworkManager is required by all three files ?

Put it in the common file, and add an accessor for the other files, for instance a static method in Solid::NetworkingPrivate.