Fixed places side panel for baloo urls
ClosedPublic

Authored by renatoo on Dec 15 2017, 2:50 PM.

Details

Summary

Make sure to convert the item original url to a valid kio url before use
it

CCBUG: 387824

Test Plan

Use side panel to access baloo urls

Diff Detail

Repository
R260 Gwenview
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
renatoo requested review of this revision.Dec 15 2017, 2:50 PM
renatoo created this revision.
renatoo updated this revision to Diff 23969.Dec 15 2017, 4:33 PM

Use explicit static function

rkflx requested changes to this revision.EditedDec 15 2017, 9:04 PM

Thanks so much for your help, Renato! Seems like a straightforward fix for someone familiar with the new additions to KFilePlacesModel ;)

  • Error messages when tree-expanding those from the sidebar.

Still happening. But don't worry about it, now that I know the trick I can easily fix it in a follow-up patch myself.

  • Access via Places panel works, but not via folders sidebar.

Can confirm that's fixed.

lib/placetreemodel.cpp
368

This won't compile with any Frameworks version < 5.41 and might need special handling via CMake.

This revision now requires changes to proceed.Dec 15 2017, 9:04 PM
rkflx edited the summary of this revision. (Show Details)Dec 15 2017, 9:05 PM
renatoo updated this revision to Diff 24070.Dec 18 2017, 2:07 PM
renatoo marked an inline comment as done.

Check KIO version before use new API

rkflx accepted this revision.Dec 18 2017, 5:19 PM

Perfect. Please commit to Applications/17.12, I'll do the follow-up fix and merge to master later.

This revision is now accepted and ready to land.Dec 18 2017, 5:19 PM
Closed by commit R260:86d754546bd1: Fixed places side panel for baloo urls (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyDec 19 2017, 2:33 PM
This revision was automatically updated to reflect the committed changes.