| albertvaka |
| KDE Connect |
Since Android Nougat, the previous way to open a file shared to android did not work anymore (using file:// urls), as marked with a TODO.
This diff implements the new way of opening files: a content provider url (content://) allows opening files through the KDE Connect app. As an added benefit, apps without external files permission can now open files received by KDE Connect.
Works for me.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Awesome! I can't try it right now, but I have some quick questions: Does it work with files outside the default destination directory? And would it be possible/wise to use the new method on Android < 24?
Ah, didn't know that was possible. As written it crashes for non-default directories, I'll fix that. It seems hard to also cover that case, but I'll investigate.
And would it be possible/wise to use the new method on Android < 24?
Maybe, depends on how many apps support the new method (I'd guess most do).
Changed so that the code no longer crashes with a custom download directory. A custom ContentProvider is needed to also allow tap-to-open for customer download directories.
Cool, thanks a ton! Eventually I think we will need the custom provider, because FileProvider is rather limited, but for now this is already much better than what we had before :)