We initially populate the QQmlPropertyMap with all keys in settings after which the properties are created for the first time. There's no need to emit value changed then.
Details
Details
- Reviewers
hein - Group Reviewers
Plasma - Commits
- R296:5c9eab26ad7b: [ConfigPropertyMap] Don't emit valueChanged on initial creation
Plasma starts normal, applet configs are loaded and persisted. Changing applet settings still has the applet react on them immediately.
I didn't actually find a case where KCoreConfigSkeleton::configChanged would be called as in writeConfigValue we block signals and we don't monitor outside config changes. Probably still needs more testing.
Saves 60ms plasmashell startup
Diff Detail
Diff Detail
- Repository
- R296 KDeclarative
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
@broulik Seems to miss some include with Qt 5.7? build fails now on CI in the patched code: https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/15/