| graesslin |
| KWin |
This Diff is half a patch, half a question. I assumed KConfigSkeleton checks the enum value in the config file on being valid. But my failing integration test tells me, that it doesn't.
This patch does the value check explicitly. Or can I somehow do the check in KConfigSkeleton (maybe I did an error when implementing it)?
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
From what I can tell if you store a string (e.g. Location) it will try to look it up in choices and return the corresponding choice number (1) but if you explicitly store a number in there, it will use that unconditionally.
| colorcorrection/manager.cpp | ||
|---|---|---|
| 161 | instead of 0 and 2 I would use enum values. | |