Make it obvious what "Display window borders for maximized windows" is for
ClosedPublic

Authored by ngraham on Dec 10 2017, 10:02 PM.

Details

Summary

Change "Display window borders for maximized windows" to "Allow resizing maximized windows from window esges"

This makes it obvious what the purpose of the feature is, and why one would want to turn it on.

CCBUG: 387675

Test Plan

Tested in KDE Neon. feature still works, and only the text is changed. Before:

After:

Diff Detail

Repository
R31 Breeze
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Dec 10 2017, 10:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 10 2017, 10:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 10 2017, 10:02 PM
ngraham edited the test plan for this revision. (Show Details)Dec 10 2017, 10:03 PM
ngraham added reviewers: hpereiradacosta, Breeze, VDG.
ngraham edited the test plan for this revision. (Show Details)Dec 10 2017, 10:07 PM

Hello Nat,
I agree the text of the option could be made better. However, the formilation you suggest make it sound as if you cannot resize maximized window without checking the option, which is not quite true: you can use the window menu, shortcuts, in case of quick-tile you can drag the window away from the corner, and then of course you can unmaximize and resize.
The other thing is that "display window borders" is confusing since in breeze (as in oxygen), window borders are invisible.
Maybe better something like
"Allow resizing maximized windows from window borders" ?

Or "Add extra space to resize maximized windows from the sides" ?

That still leaves the ambiguity that you noticed that when the selected window border size (for unmaximized windows) is either "no border" or "no side borders", nothing is changed on the side and bottom of maximized windows, whether the option is checked or not.
One could either: update the title to "Allow resizing maximized windows from window borders (if any)" or add a more detailed tooltip/what's this to the option. (tooltip would be better, what's this being mostly deprecated/inexistant in kde)
What do you think ?

Hugo

ngraham added a comment.EditedDec 11 2017, 11:47 PM

Those are good ideas, @hpereiradacosta. How about "Allow resizing maximized windows from window edges"? This one doesn't have a problem if you have No Borders set.

ngraham updated this revision to Diff 23783.Dec 11 2017, 11:54 PM

Change to "Allow resizing maximized windows from window edges"

ngraham edited the test plan for this revision. (Show Details)Dec 12 2017, 12:05 AM
ngraham edited the summary of this revision. (Show Details)
hpereiradacosta accepted this revision.Dec 12 2017, 8:38 AM

Thanks a lot. Works for me.

This revision is now accepted and ready to land.Dec 12 2017, 8:38 AM
ngraham closed this revision.Dec 12 2017, 1:23 PM

Side note: feel free to push the same thing in the oxygen repo.

Sounds good!

Done, thanks!

abetts added a subscriber: abetts.Dec 12 2017, 3:05 PM

Looks good!