In preparation for T6345 this diff unifies the delegates for the single album view and the all tracks view.
This makes adding i.e. new actions to both delegates a lot easier as they now share most of the code.
Two new track delegates are replacing the old ones. The delegate for the single album view only wraps around the shared code.
Included functional changes:
-animations in the single album view
-makes more data available in the models
-adds disc number handling for the all tracksview
-converted actions to use signals
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:612eb8858914: unify track delegate handling
album view and all tracks view work as before
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Branch
- track_delegate
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
While adding the metadata view for the tracks I realized that I had to duplicate a lot of code between the AudioTrackDelegate and the MediaTracksDelegate. They mostly do the same things, and sometimes implement those even differently. Since they also differ in some aspects, sharing code was not as easy as I initially anticipated, and this is what I came up with.
One screenshot for the only (static) visual change: add a label indicating the disc number in the all track views:
Comment Actions
Thanks for your work.
I have not finished reviewing this work. I noticed one thing that is broken. I cannot navigate the tracks of an album with the keyboard arrows.
Could you also test with the -reverse command line option ? I will also do it.
| src/MediaTracksDelegate.qml | ||
|---|---|---|
| 88 | When clicking on a track inside an album, a warning is emitted by this line. | |
Comment Actions
fixed some typos locally that eliminate those warnings, but noticed that this needs some more work, for example there are also issues with select. will update later. sorry, I put this on phabricator to soon.
btw navigation with keys up and down is supposed to work? never did here...
Comment Actions
I did check with the master branch and it worked. I have read that qt quick controls v1 do some special handling of touch screen and my laptop has one. Maybe, it is related since my work computer under windows lacks one and lacks keyboard navigation.
Comment Actions
Thanks for your work. Works fine for me including keyboard navigation with my plasma running laptop.