in the wallpaper config dialog
there was custom code duplicating listing of kpackage, just wrong
(if the same wallpaper was installed in more than one place, the
config file qml was taken from the one with least priority)
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:aeecbcd9f839: port wallpaper config fialog to Package::fileUrl
wallpaper dialog works again with qresource based packages
also they load the proper config ui qml file when more than one
instance of plasmashell is installed
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- phab/fileurlwallpaper
- Lint
No Linters Available - Unit
No Unit Test Coverage
shell/containmentconfigview.cpp | ||
---|---|---|
127 | Does that still work given you changed filePath to fileUrl.toString()? |
shell/containmentconfigview.cpp | ||
---|---|---|
127 | yes, seems to work fine |
Comment Actions
Works with my awesome firework wallpaper from 2 years ago.
shell/containmentconfigview.cpp | ||
---|---|---|
126 | the old code has an if !package.valid {continue} do we need that? |