Remove unused persistentsetmap.h
ClosedPublic

Authored by kossebau on Dec 5 2017, 5:29 PM.

Details

Summary

Added 2008 in e13432be5a021c8e2116e0d2a4114e53f612a4dc but no code found
committed which picks up that header and its classes

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Dec 5 2017, 5:29 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 5 2017, 5:29 PM
kossebau requested review of this revision.Dec 5 2017, 5:29 PM
mwolff added a subscriber: mwolff.Dec 5 2017, 5:38 PM

this was used by oldcpp, and we could (should!) actually leverage this by kdev-clang to store more information about the parsing environment, such that we can later check whether it has changed and also show the user what was used. That said, maybe persisting a simple vector of strings is enough for that purpose...

kossebau added a comment.EditedDec 5 2017, 5:41 PM

this was used by oldcpp, and we could (should!) actually leverage this by kdev-clang to store more information about the parsing environment, such that we can later check whether it has changed and also show the user what was used. That said, maybe persisting a simple vector of strings is enough for that purpose...

Was that in some branch? Grepping with gitk in changes on the kdevelop repo did not have any hits, neither "PersistentSetMap" nor "persistentsetmap.h" (besides the introducing commit itself).

kfunk accepted this revision.Dec 19 2017, 10:35 PM
kfunk added a subscriber: kfunk.

this was used by oldcpp, and we could (should!) actually leverage this by kdev-clang to store more information about the parsing environment, such that we can later check whether it has changed and also show the user what was used. That said, maybe persisting a simple vector of strings is enough for that purpose...

Was that in some branch? Grepping with gitk in changes on the kdevelop repo did not have any hits, neither "PersistentSetMap" nor "persistentsetmap.h" (besides the introducing commit itself).

Agreed. I can't find code that use this class either.

Maybe indeed remove? We can start over -- it's not like anyone still understands this code anyway, anymore.

This revision is now accepted and ready to land.Dec 19 2017, 10:35 PM

oh, interesting. then I'm mixing up the type. go for it then.

This revision was automatically updated to reflect the committed changes.