Fix regression from KWin 5.9 regarding quick tiling
ClosedPublic

Authored by graesslin on Dec 4 2017, 4:25 PM.

Details

Summary

The regression got introduced with 9934f5b57537feae54afd0c4366c90253638ada2.
The order when setMaximize(false, false) was called changed in regard to
when the quick tiling mode was adjusted. But just changing the ordering
back was no solution as that would cause regressions in other areas
(unit tests fail).

This change builds up on the support for geometry update blocker on
Wayland to be able to better support this situation without causing
further regressions.

Also this change rethinks the code area. There is an idea behind
temporarily setting the quick tile mode to none and that is even
documented in a comment: it should not confuse maximize. So let's do
exactly that: call the maximize in the block where the quick tile
mode is temporarily wrong. As that is only one branch the else branch
performs the same steps.

BUG: 376104
FIXED-IN: 5.12.0

Test Plan

Confirmation in bug report that patch fixes issue

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Dec 4 2017, 4:25 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 4 2017, 4:25 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Dec 4 2017, 4:25 PM
davidedmundson accepted this revision.Dec 4 2017, 5:04 PM
This revision is now accepted and ready to land.Dec 4 2017, 5:04 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 4 2017, 5:04 PM
ngraham added a subscriber: ngraham.Dec 4 2017, 5:05 PM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptDec 4 2017, 5:05 PM

@ngraham may I ask why you removed Plasma?

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 4 2017, 5:26 PM

I didn't; I just subscribed myself by clicking on the "Subscribe" button. No idea why that would remove Plasma...

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptDec 4 2017, 5:30 PM

And now posting that comment appears to have done the same thing. Bizarre.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 4 2017, 5:31 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptDec 4 2017, 5:31 PM