Diffusion KWin 8a2796d280dd

Fix regression from KWin 5.9 regarding quick tiling

Authored by graesslin on Nov 22 2017, 7:57 PM.

Description

Fix regression from KWin 5.9 regarding quick tiling

Summary:
The regression got introduced with 9934f5b57537feae54afd0c4366c90253638ada2.
The order when setMaximize(false, false) was called changed in regard to
when the quick tiling mode was adjusted. But just changing the ordering
back was no solution as that would cause regressions in other areas
(unit tests fail).

This change builds up on the support for geometry update blocker on
Wayland to be able to better support this situation without causing
further regressions.

Also this change rethinks the code area. There is an idea behind
temporarily setting the quick tile mode to none and that is even
documented in a comment: it should not confuse maximize. So let's do
exactly that: call the maximize in the block where the quick tile
mode is temporarily wrong. As that is only one branch the else branch
performs the same steps.

BUG: 376104
FIXED-IN: 5.12.0

Test Plan: Confirmation in bug report that patch fixes issue

Reviewers: KWin, Plasma

Subscribers: plasma-devel, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D9178

Details

Committed
graesslinDec 4 2017, 4:25 PM
Differential Revision
D9178: Fix regression from KWin 5.9 regarding quick tiling
Parents
R108:a8be959b8f62: Implement geometry update blocking in ShellClient
Branches
Unknown
Tags
Unknown