Differential D9130

[widgetexplerer] Destroy download dialog at time of widget
ClosedPublic
Actions

Authored by anthonyfieroni on Dec 3 2017, 2:00 PM.

Details

Reviewers
davidedmundson
broulik
mart
Commits
R120:84a29ef86380: [widgetexplorer] Make sure KNS download dialog is destroyed
Summary

CCBUG: 355464

Test Plan

When DownloadDialog is not destroyed KNS3 engine not store registry of installed/upgradable stuff. See bug report

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Dec 3 2017, 2:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 3 2017, 2:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Dec 3 2017, 2:00 PM
anthonyfieroni updated this revision to Diff 23420.Dec 4 2017, 12:16 PM

Take ownership of DownloadDialog. Remove slot that not present.

anthonyfieroni updated this revision to Diff 23459.Dec 4 2017, 6:33 PM

Oh i revert patch, WidgetExplorer is not widget, what DownloadDialog expects as parent.

anthonyfieroni updated this revision to Diff 23462.Dec 4 2017, 6:47 PM

Ability to detect delete on close.

anthonyfieroni added a reviewer: mart.Dec 6 2017, 1:51 PM

Anyone against?

davidedmundson accepted this revision.Dec 6 2017, 2:26 PM
This revision is now accepted and ready to land.Dec 6 2017, 2:26 PM
Closed by commit R120:84a29ef86380: [widgetexplorer] Make sure KNS download dialog is destroyed (authored by anthonyfieroni). · Explain WhyDec 6 2017, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23580

View Options

components/shellprivate/widgetexplorer/widgetexplorer.cpp

Loading...