Differential D9112

Explicitly emit overlaysChanged in the setter rather than connecting to it
ClosedPublic
Actions

Authored by broulik on Dec 2 2017, 5:09 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:da2b6e270fb6: [Icon Item] Explicitly emit overlaysChanged in the setter rather than…
Summary

There's literally just one place where this thing changes so just emit the signal there and call it a day.

Test Plan

Overlays still change fine and show up on startup (the warning icon on non-exec desktop files)

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 2 2017, 5:09 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 2 2017, 5:09 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 2 2017, 5:09 PM
davidedmundson accepted this revision.Dec 2 2017, 5:11 PM
This revision is now accepted and ready to land.Dec 2 2017, 5:11 PM
Closed by commit R242:da2b6e270fb6: [Icon Item] Explicitly emit overlaysChanged in the setter rather than… (authored by broulik). · Explain WhyDec 2 2017, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23294

View Options

src/declarativeimports/core/iconitem.cpp

Loading...