Differential D9086

[KWindowEffectsPrivateX11] Add reserve() call
ClosedPublic
Actions

Authored by broulik on Dec 1 2017, 11:50 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R278:b82e40fb2fc1: [KWindowEffectsPrivateX11] Add reserve() call
Summary

We know how many items we're going to add to the vector.

Test Plan

QRegion iterators are new in Qt 5.8 so we cannot use them yet.

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 1 2017, 11:50 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 1 2017, 11:50 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 1 2017, 11:50 AM
broulik updated this revision to Diff 23213.
broulik edited the test plan for this revision. (Show Details)
  • Take into account that below we're adding 16 additional items from rawData
graesslin accepted this revision.Dec 1 2017, 6:40 PM
This revision is now accepted and ready to land.Dec 1 2017, 6:40 PM
Closed by commit R278:b82e40fb2fc1: [KWindowEffectsPrivateX11] Add reserve() call (authored by broulik). · Explain WhyDec 1 2017, 9:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23236

View Options

src/platforms/xcb/kwindoweffects.cpp

Loading...