This is copied from KScreenlocker, but will be utilized in Baloo too.
Details
- Reviewers
graesslin krop - Commits
- R240:c30802019895: Add FindSeccomp to find-modules
- Autotests are working
- KScreenlocker and Baloo build with seccomp enabled
Diff Detail
- Repository
- R240 Extra CMake Modules
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
find-modules/FindSeccomp.cmake | ||
---|---|---|
51–56 | I'm not sure about this. @graesslin is this nessecarry? Most find-modules don't check for the CMake version, and we don't do anything special here. |
find-modules/FindSeccomp.cmake | ||
---|---|---|
51–56 | No idea, that's copy pasted from some other cmake modules. |
find-modules/FindSeccomp.cmake | ||
---|---|---|
51–56 | Well, based on the fact that no other find-module includes such a check, I will remove it. |
find-modules/FindSeccomp.cmake | ||
---|---|---|
12 ↗ | (On Diff #22931) | so, what about naming your variables Seccomp_LIBRARIES and Seccomp_INCLUDE_DIRS in the file ? |
24 ↗ | (On Diff #22931) | One author per line |
56 ↗ | (On Diff #22931) | Seccomp_INCLUDE_DIRS |
62 ↗ | (On Diff #22931) | Seccomp_LIBRARIES |
74–75 ↗ | (On Diff #22931) | same thing here |
83–85 ↗ | (On Diff #22931) | and there |
89 ↗ | (On Diff #22931) | here as well |
Thank you, missed this when renaming the docs.
find-modules/FindSeccomp.cmake | ||
---|---|---|
12 ↗ | (On Diff #22931) | Well....I'm for it! ;) |
Mostly good. Last question : is the version important ? If yes, please add an additional way to get the version if Seccomp_VERSION is empty. (you can parse seccomp.h to find it, look at the other Find*.cmake modules for examples)
find-modules/FindSeccomp.cmake | ||
---|---|---|
3 | nitpick : missing 2 dashes | |
51 | Also add the QUIET keyword here | |
54 | This doesn't look useful. Looking at my pkgconfig file, the cflags just adds the include dir. If neither baloo or kscreenlocker use it, just remove this line and #85. |
find-modules/FindSeccomp.cmake | ||
---|---|---|
22 ↗ | (On Diff #22931) | 5.44.0 |