Differential D8949

Update PGPKey display
ClosedPublic
Actions

Authored by knauss on Nov 22 2017, 2:55 PM.

Details

Reviewers
aheinecke
Group Reviewers
KDE PIM
Commits
R81:874b16820d86: Make it possible to show corretly if the localstore job is running.
Summary
  • Show the key material of the mime part everytime.
  • test if the keymaterial in the mime content is valid.
  • show if key is unknown.
  • add test for showSignuatureDetails
Test Plan

run tests

Diff Detail

Repository
R81 KDE PIM Addons
Branch
dev
Lint
No Linters Available
Unit
No Unit Test Coverage
knauss created this revision.Nov 22 2017, 2:55 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 22 2017, 2:55 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss updated this revision to Diff 22749.Nov 22 2017, 3:10 PM

update the error string.

knauss retitled this revision from Make it possible to show corretly if the localstore job is running. to Update PGPKey display.Nov 22 2017, 3:12 PM
knauss edited the summary of this revision. (Show Details)
knauss edited the test plan for this revision. (Show Details)
knauss added reviewers: KDE PIM, kde-i18n-doc, dvratil, aheinecke.
knauss added a comment.Nov 22 2017, 3:15 PM

This should go to Applications/17.12

@kde-i18n-doc: the strings that have been added are:

  • "This key is unknown, it could not be found in your local keyring. You may want to import this key."
  • "No valid key data in file."
aheinecke accepted this revision as: aheinecke.Nov 27 2017, 9:17 AM

Looks good to me. Nice extension. Thanks!

This revision is now accepted and ready to land.Nov 27 2017, 5:20 PM
Closed by commit R81:874b16820d86: Make it possible to show corretly if the localstore job is running. (authored by knauss). · Explain WhyNov 27 2017, 5:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMcmake/modules/kdepim_add_gpg_crypto_test.cmake (59 lines)
AMcmake/modules/kdepim_generate_crypto_test_wrapper.cmake (53 lines)
Mplugins/messageviewer/bodypartformatter/autotests/CMakeLists.txt (16 lines)
AMplugins/messageviewer/bodypartformatter/autotests/data/message-with-openpgp-key.mbox.html.details (67 lines)
AMplugins/messageviewer/bodypartformatter/autotests/data/message-with-openpgp-key.mbox.html.running (67 lines)
AMplugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox (717 lines)
AMplugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox.html (64 lines)
AMplugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox.html.details (65 lines)
AMplugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox.html.running (64 lines)
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/CMakeLists.txt (10 lines)
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr-cache.d/DIR.txt (3 lines)
AM(bin)plugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr-cache.d/crl-4E31CEB57DDD4A7B9991AB05507B1ED4293FF952.db
AM(bin)plugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr-cache.d/crl-7F2A402CBB016A9146D613568C89D3596A4111AA.db
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr.conf (8 lines)
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/gpg-agent.conf.in (10 lines)
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/gpg.conf (244 lines)
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/gpgsm.conf.in (10 lines)
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/pinentry-fake.sh (9 lines)
AM(bin)plugins/messageviewer/bodypartformatter/autotests/gnupg_home/private-keys-v1.d/1AA8BA52430E51AE249AF0DA97D59F869E4101A8.key
AM(bin)plugins/messageviewer/bodypartformatter/autotests/gnupg_home/pubring.gpg
AM(bin)plugins/messageviewer/bodypartformatter/autotests/gnupg_home/pubring.kbx
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/scdaemon.conf (8 lines)
AM(bin)plugins/messageviewer/bodypartformatter/autotests/gnupg_home/secring.gpg
AM(bin)plugins/messageviewer/bodypartformatter/autotests/gnupg_home/trustdb.gpg
AMplugins/messageviewer/bodypartformatter/autotests/gnupg_home/trustlist.txt (11 lines)
Mplugins/messageviewer/bodypartformatter/autotests/rendertest.h (2 lines)
Mplugins/messageviewer/bodypartformatter/autotests/rendertest.cpp (64 lines)
Mplugins/messageviewer/bodypartformatter/autotests/testobjecttreesource.h (9 lines)
Mplugins/messageviewer/bodypartformatter/gnupgwks/pgpkeyformatter.cpp (33 lines)
Mplugins/messageviewer/bodypartformatter/gnupgwks/pgpkeymessagepart.h (4 lines)
Mplugins/messageviewer/bodypartformatter/gnupgwks/pgpkeymessagepart.cpp (12 lines)
Mplugins/messageviewer/bodypartformatter/gnupgwks/templates/pgpkeymessagepart.html (42 lines)

Diff 22744

View Options

cmake/modules/kdepim_add_gpg_crypto_test.cmake

Loading...
View Options

cmake/modules/kdepim_generate_crypto_test_wrapper.cmake

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/CMakeLists.txt

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/data/message-with-openpgp-key.mbox.html.details

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/data/message-with-openpgp-key.mbox.html.running

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox.html

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox.html.details

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/data/message-with-two-openpgp-key.mbox.html.running

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/CMakeLists.txt

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr-cache.d/DIR.txt

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr-cache.d/crl-4E31CEB57DDD4A7B9991AB05507B1ED4293FF952.db

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr-cache.d/crl-7F2A402CBB016A9146D613568C89D3596A4111AA.db

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/dirmngr.conf

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/gpg-agent.conf.in

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/gpg.conf

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/gpgsm.conf.in

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/pinentry-fake.sh

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/private-keys-v1.d/1AA8BA52430E51AE249AF0DA97D59F869E4101A8.key

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/pubring.gpg

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/pubring.kbx

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/scdaemon.conf

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/secring.gpg

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/trustdb.gpg

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/gnupg_home/trustlist.txt

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/rendertest.h

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/rendertest.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/autotests/testobjecttreesource.h

Loading...
View Options

plugins/messageviewer/bodypartformatter/gnupgwks/pgpkeyformatter.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/gnupgwks/pgpkeymessagepart.h

Loading...
View Options

plugins/messageviewer/bodypartformatter/gnupgwks/pgpkeymessagepart.cpp

Loading...
View Options

plugins/messageviewer/bodypartformatter/gnupgwks/templates/pgpkeymessagepart.html

Loading...