By default, capture the cursor when invoking Active Window method with the global hotkey via Dbus
AbandonedPublic

Authored by ngraham on Nov 19 2017, 4:52 AM.

Details

Reviewers
dfaure
apol
kossebau
Group Reviewers
Spectacle
Summary

BUG: 386481

Test Plan

Tested in KDE Neon. With this change, the cursor is now captured when Active Window mode is invoked via Dbus using the Meta+Print keyboard shortcut.

Diff Detail

Repository
R166 Spectacle
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Nov 19 2017, 4:52 AM
kossebau resigned from this revision.Nov 29 2017, 4:20 PM

The referenced bug number misses a 1, should be 386481 -> https://bugs.kde.org/show_bug.cgi?id=386481

What is the motivation for this change?
Seems including the cursor or not when invoking the shortcut might be something different people would have different expectations for. E.g. I would not expect the cursor to be captured.
This seems a random change to me, ideally such things should be based on design and use cases analysis, not single users poking by a bug report (which misses all those users happy with the current behaviour).

My 2 cents as user who just recently fixed a bug in Spectacle, but is not a maintainer (thus also resigning from this review).

ngraham edited the summary of this revision. (Show Details)Nov 29 2017, 4:22 PM
ngraham added a comment.EditedNov 29 2017, 4:28 PM

This only changes the default behavior when you invoke spectacle using a global keyboard shortcut. One argument in favor of changing this is that it brings consistency, since the cursor is captured by default when you use the main UI.

Perhaps what we should do is add a new dbus invocation that doesn't specify whether or not to capture the cursor and makes the decision itself by reading Spectacle's pre-existing user preferences.

ngraham abandoned this revision.Jan 28 2018, 5:31 PM

Abandoning this since there's no consensus on whether or not this is the right approach.