Differential D8832

Fix highlight/annotation clipping with Qt scaling
ClosedPublic
Actions

Authored by davidedmundson on Nov 15 2017, 11:19 PM.

Details

Reviewers
rkflx
Commits
R223:1a3dc7d8e05f: Fix highlight/annotation clipping with Qt scaling
R223:ab433f701af8: Fix highlight/annotation clipping with Qt scaling
Summary

pixelValue/pixelValue will give us a normalised value.

Normalised values shouldn't be modified by a device pixel ratio.
We want scaledRect not dScaledRect.

BUG: 386110

Test Plan

Searched for text. Zoomed in, panned about
Created annotations, they still seemed to work

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Okular. · View Herald TranscriptNov 15 2017, 11:19 PM
Restricted Application added a subscriber: Okular. · View Herald Transcript
sander added a subscriber: sander.Nov 16 2017, 8:57 AM

Thanks for the patch. It seems to solve the problem for me.

rkflx accepted this revision.Nov 23 2017, 11:01 PM
rkflx added a subscriber: rkflx.

LGTM, solves the bug for me too and I could not break anything when testing. As nobody brought up any issues so far, I'd say this can land (stable branch).

This revision is now accepted and ready to land.Nov 23 2017, 11:01 PM
Closed by commit R223:1a3dc7d8e05f: Fix highlight/annotation clipping with Qt scaling (authored by davidedmundson). · Explain WhyNov 23 2017, 11:04 PM
This revision was automatically updated to reflect the committed changes.
rkflx added a comment.Nov 23 2017, 11:24 PM

Closed by commit R223:1a3dc7d8e05f

While master is quite "stable", I meant Applications/17.12, of course ;)

Will cherry-pick tomorrow…

davidedmundson added a comment.Nov 23 2017, 11:31 PM

Oops, I didn't read that. :/ Sorry.

cherry-picked.

Revision Contents
Changeset List

PathPackages
Mui/pagepainter.cpp (8 lines)

Diff 22862

View Options

ui/pagepainter.cpp

Loading...