Update the ProjectClip::thumbProducer to be a std::shared_ptr and use it in the
ThumbJob.
Using the originalProducer() causes crashes when using movit acceleration.
Update the ProjectClip::thumbProducer to be a std::shared_ptr and use it in the
ThumbJob.
Using the originalProducer() causes crashes when using movit acceleration.
No Linters Available |
No Unit Test Coverage |
LGTM. Please note that we have a .clang-format file in the top directory to help you format your code (I can spot some extra spaces here and there :p )
I think I do have commit access, I never used phabricator before so I was not sure if I had to merge manually, or if it had a "Merge" button like github does.
So how does merging works? Should I just use git to push the changes or do I have to use arc? Sorry, I have never used phabricator before, still learning how things work here.
See https://community.kde.org/Infrastructure/Phabricator#Workflow. You can use arc land or git push if you don't need to squash