Commit ee5b036c1df4776a258c0d8067fd2eaf18875829 added a new FindPulseAudio module with a slightly different syntax than the old one. Since the old module was removed with commit 7574022825804db2274bba992d6fc4a4817c1536 plasma-desktop and plasma-pa are broken. Just adding the old syntax as synonym for fixing this.
Details
Details
- Reviewers
krop - Group Reviewers
Frameworks - Commits
- R240:c02178fa380c: restore old behaviour of FindPulseAudio
compile tested with plasma-desktop
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
you also need set(PULSEAUDIO_FOUND "${PulseAudio_FOUND}"). You then have to move the compat variables below "find_package_handle_standard_args".
Please also fix the mark_as_advanced() line to match the renamed vars.
Comment Actions
Please commit after fixing the last issue.
| find-modules/FindPulseAudio.cmake | ||
|---|---|---|
| 123 | PulseAudio_INCLUDE_DIRS PULSEAUDIO_INCLUDE_DIR | |
Comment Actions
v3 should address all comments
as I don't have commit rights, could one of KDE devs commit it?