Resolves T7185
Use the new folder-stash icon introduced in https://cgit.kde.org/breeze-icons.git/commit/?id=b909a8008a7e3ffabb090bc82127ebb561f58597
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Maniphest Tasks
- T7185: Icon for kio-stash action
- Commits
- R318:0905b13dc49f: Use new folder-stash icon
Tested in KDE Neon. Dolphin now uses the new icon is kio-stash is installed:
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 1099 | Please use the old folder-stash icon as fallback (in the fromTheme call), in case the user has a version of breeze-icons older then 5.40 | |
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 1099 | This probably does not compile, see http://doc.qt.io/qt-5/qicon.html#fromTheme-1 | |
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 1099 | EDIT: Actually, it probably does compile, but you want QIcon::fromTheme() as a fallback, not an icon loaded from a filename, which is the implicit result of QIcon(QString). | |
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 1099 | And thinking about it, fallbacks with QIcon::fromTheme() are probably useless, because our icon loader does automatic fallback according to XDG spec. In other words, if "folder-stash" is not available, it will load "folder". Even if this was not available, it would load a default "unknown" icon. If you really want the fallback to a different icon to work, you probably need to use KIconLoader classes directly. | |
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 1099 |
Oh, that's probably good enough then. | |