Fix building the bittorrent plugin
ClosedPublic

Authored by wbauer on Nov 8 2017, 12:20 PM.

Details

Summary
  • use the correct cmake variable to test whether it should be built (it wasn't built at all even if libktorrent was available)
  • port KUrl to QUrl, necessary by changes to the rest of the code
  • add missing link libraries
  • add missing includes, correct wrong ones
  • some other changes required to make it compile
Test Plan
  • the plugin is actually built now (if libktorrent is found) and it compiles fine
  • it shows up in kget's settings
  • added a torrent, the download started (with the multiseg plugin disabled, which still has problems)

Diff Detail

Repository
R433 KGet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.Nov 8 2017, 12:20 PM
stikonas accepted this revision.Nov 8 2017, 3:26 PM
stikonas added a subscriber: stikonas.

Looks fine to me.

This revision is now accepted and ready to land.Nov 8 2017, 3:26 PM
This revision was automatically updated to reflect the committed changes.