Differential D8649

move detecting comments to before operators so -- is interpreted as a comment, not an operator
AbandonedPublic
Actions

Authored by cullmann on Nov 4 2017, 8:51 AM.

Details

Reviewers
dhaumann
genethomas
Group Reviewers
Framework: Syntax Highlighting
Summary
  • comments are not correctly detected in 3 of the 4 sql .xml syntax definitions
Test Plan

load a test.sql file into my editor which reads KDE syntax highlighting .xml files
checking that -- and /* */ comments are correctly rendered

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
genethomas created this revision.Nov 4 2017, 8:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 4 2017, 8:51 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested changes to this revision.Jan 28 2018, 11:21 AM
dhaumann added a subscriber: dhaumann.

@genethomas Unfortunately we are so late with the review that your patch does not apply cleanly anymore. Could you update your patch?

This revision now requires changes to proceed.Jan 28 2018, 11:21 AM
cullmann commandeered this revision.Nov 24 2018, 4:55 PM
cullmann added a reviewer: genethomas.
cullmann added a subscriber: cullmann.

These fixes are already in the current state in our git ;=)
Thanks for the patch anyways!

Restricted Application added a project: Kate. · View Herald TranscriptNov 24 2018, 4:55 PM
Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. · View Herald Transcript
cullmann abandoned this revision.Nov 24 2018, 4:55 PM

Already fix in current master.

Revision Contents
Changeset List

Diff 21860

View Options

data/syntax/sql-mysql.xml

Loading...
View Options

data/syntax/sql-postgresql.xml

Loading...
View Options

data/syntax/sql.xml

Loading...